pgsql: Re-add BRIN isolation test
Re-add BRIN isolation test
This time, instead of using a core isolation test, put it on its own
test module; this way it can require the pageinspect module to be
present before running.
The module's Makefile is loosely modeled after test_decoding's, so that
it's easy to add further tests for either pg_regress or isolationtester
later.
Backpatch to 9.5.
Branch
------
master
Details
-------
http://git.postgresql.org/pg/commitdiff/672e3ec0e93e3d2d5549b95f73b2a3ab58714146
Modified Files
--------------
src/test/modules/Makefile | 1 +
src/test/modules/brin/.gitignore | 3 ++
src/test/modules/brin/Makefile | 30 +++++++++++++
.../summarization-and-inprogress-insertion.out | 39 +++++++++++++++++
.../summarization-and-inprogress-insertion.spec | 44 ++++++++++++++++++++
5 files changed, 117 insertions(+)
--
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers
Alvaro Herrera wrote:
Re-add BRIN isolation test
This time, instead of using a core isolation test, put it on its own
test module; this way it can require the pageinspect module to be
present before running.The module's Makefile is loosely modeled after test_decoding's, so that
it's easy to add further tests for either pg_regress or isolationtester
later.
Argh, and this now broke MSVC :-(
I'm tempted to change this block from Mkvcbuild.pm,
else
{
croak "Could not determine contrib module type for $n\n";
}
(i.e. it doesn't find any of PROGRAM, MODULES, MODULE_big in the
Makefile) so that instead of raising an error it simply skips the module
altogether. That's pretty much equivalent to what Make would do. Maybe
restrict this behavior to within src/test/modules.
--
�lvaro Herrera http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
On 08/13/2015 04:26 PM, Alvaro Herrera wrote:
Alvaro Herrera wrote:
Re-add BRIN isolation test
This time, instead of using a core isolation test, put it on its own
test module; this way it can require the pageinspect module to be
present before running.The module's Makefile is loosely modeled after test_decoding's, so that
it's easy to add further tests for either pg_regress or isolationtester
later.Argh, and this now broke MSVC :-(
I'm tempted to change this block from Mkvcbuild.pm,
else
{
croak "Could not determine contrib module type for $n\n";
}(i.e. it doesn't find any of PROGRAM, MODULES, MODULE_big in the
Makefile) so that instead of raising an error it simply skips the module
altogether. That's pretty much equivalent to what Make would do. Maybe
restrict this behavior to within src/test/modules.
An immediate solution would probably be to add it to @contrib_excludes.
cheers
andrew
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
Andrew Dunstan wrote:
On 08/13/2015 04:26 PM, Alvaro Herrera wrote:
Argh, and this now broke MSVC :-(
An immediate solution would probably be to add it to @contrib_excludes.
Ah, that seems simpler. Pushed that, let's see if it cures the problem.
--
�lvaro Herrera http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers