Small typo in timeline.h regarding the meaning of infinity for timeline history entry

Started by Michael Paquierover 10 years ago3 messageshackers
Jump to latest
#1Michael Paquier
michael@paquier.xyz

Hi all,

timeline.h quotes that the end point of timeline history entry means
infinity when its value is 0. But that's not completely true, I think
that what is meant here is InvalidXLogRecPtr:
 {
        TimeLineID      tli;
        XLogRecPtr      begin;                  /* inclusive */
-       XLogRecPtr      end;                    /* exclusive, 0 means
infinity */
+       XLogRecPtr      end;                    /* exclusive,
InvalidXLogRecPtr means
+                                                                * infinity */
 } TimeLineHistoryEntry;

And the code leads into this direction as well.
Regards,
--
Michael

Attachments:

20150910_timeline_typo.patchtext/x-diff; charset=US-ASCII; name=20150910_timeline_typo.patchDownload+2-1
#2Fujii Masao
masao.fujii@gmail.com
In reply to: Michael Paquier (#1)
Re: Small typo in timeline.h regarding the meaning of infinity for timeline history entry

On Thu, Sep 10, 2015 at 2:37 PM, Michael Paquier
<michael.paquier@gmail.com> wrote:

Hi all,

timeline.h quotes that the end point of timeline history entry means
infinity when its value is 0. But that's not completely true, I think
that what is meant here is InvalidXLogRecPtr:
{
TimeLineID      tli;
XLogRecPtr      begin;                  /* inclusive */
-       XLogRecPtr      end;                    /* exclusive, 0 means
infinity */
+       XLogRecPtr      end;                    /* exclusive,
InvalidXLogRecPtr means
+                                                                * infinity */
} TimeLineHistoryEntry;

And the code leads into this direction as well.

Thanks for the report and patch! Applied.

Regards,

--
Fujii Masao

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

#3Michael Paquier
michael@paquier.xyz
In reply to: Fujii Masao (#2)
Re: Small typo in timeline.h regarding the meaning of infinity for timeline history entry

On Tue, Sep 15, 2015 at 7:38 AM, Fujii Masao wrote:

Thanks for the report and patch! Applied.

Thanks!
--
Michael

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers