Fix unclear comments in tablecmds.c
Came across a couple of unclear comments about functions returning
ObjectAddress. Attached fixes them.
Thanks,
Amit
Attachments:
fix-unclear-comments-objectaddress.patchtext/x-diff; name=fix-unclear-comments-objectaddress.patchDownload
diff --git a/src/backend/commands/tablecmds.c b/src/backend/commands/tablecmds.c
index 7668c9d..403582c 100644
--- a/src/backend/commands/tablecmds.c
+++ b/src/backend/commands/tablecmds.c
@@ -5673,7 +5673,7 @@ ATPrepDropColumn(List **wqueue, Relation rel, bool recurse, bool recursing,
}
/*
- * Return value is that of the dropped column.
+ * Return value is the address of the dropped column.
*/
static ObjectAddress
ATExecDropColumn(List **wqueue, Relation rel, const char *colName,
@@ -10376,7 +10376,7 @@ MergeConstraintsIntoExisting(Relation child_rel, Relation parent_rel)
* coninhcount and conislocal for inherited constraints are adjusted in
* exactly the same way.
*
- * Return value is the OID of the relation that is no longer parent.
+ * Return value is the address of the relation that is no longer parent.
*/
static ObjectAddress
ATExecDropInherit(Relation rel, RangeVar *parent, LOCKMODE lockmode)
Amit Langote wrote:
Came across a couple of unclear comments about functions returning
ObjectAddress. Attached fixes them.
Thanks, pushed to 9.5 and master.
--
�lvaro Herrera http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
Amit Langote wrote:
Came across a couple of unclear comments about functions returning
ObjectAddress. Attached fixes them.
Thanks, applied.
--
�lvaro Herrera http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
On 2015/10/16 0:21, Alvaro Herrera wrote:
Amit Langote wrote:
Came across a couple of unclear comments about functions returning
ObjectAddress. Attached fixes them.Thanks, pushed to 9.5 and master.
Thanks, Alvaro.
Regards,
Amit
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers