Small fix in pg_rewind (redundant declaration)

On Thu, Dec 17, 2015 at 9:23 PM, YUriy Zhuravlev
<u.zhuravlev@postgrespro.ru> wrote:

Hello hackers.
I've stumbled upon a strange code.
In src/bin/pg_rewind/datapagemap.h we decalre:
extern void datapagemap_destroy(datapagemap_t *map);
But nowhere is implemented. I think the declaration of this function must be
removed.
I'm not sure that this trivial things needed patch.

Nicely noticed. That's a bug present as well in the 9.3 and 9.4
versions of pg_rewind (just fixed it there). datapagemap_create can be
additionally removed.
--
Michael

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Michael Paquier <michael.paquier@gmail.com> writes:

On Thu, Dec 17, 2015 at 9:23 PM, YUriy Zhuravlev
<u.zhuravlev@postgrespro.ru> wrote:

Hello hackers.
I've stumbled upon a strange code.
In src/bin/pg_rewind/datapagemap.h we decalre:
extern void datapagemap_destroy(datapagemap_t *map);
But nowhere is implemented. I think the declaration of this function must be
removed.
I'm not sure that this trivial things needed patch.

Nicely noticed. That's a bug present as well in the 9.3 and 9.4
versions of pg_rewind (just fixed it there). datapagemap_create can be
additionally removed.

Done.

regards, tom lane

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

On Fri, Dec 18, 2015 at 10:22 AM, Tom Lane <tgl@sss.pgh.pa.us> wrote:

Done.

Thanks.
--
Michael

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers