pg_upgrade tests running calling psql without --no-psqlrc

Started by Michael Paquierover 10 years ago3 messageshackers
Jump to latest
#1Michael Paquier
michael@paquier.xyz

Hi all,

Since commit d5563d7d, -c does not imply any more --no-psqlrc hence
the tests of pg_upgrade may run with a custom psqlrc file loaded. I
think that we had better add -X to avoid that, like in the patch
attached.
Thoughts?
--
Michael

Attachments:

20151228_pgupgrade_psql_fix.patchtext/x-patch; charset=US-ASCII; name=20151228_pgupgrade_psql_fix.patchDownload+2-2
#2Pavel Stehule
pavel.stehule@gmail.com
In reply to: Michael Paquier (#1)
Re: pg_upgrade tests running calling psql without --no-psqlrc

2015-12-28 14:21 GMT+01:00 Michael Paquier <michael.paquier@gmail.com>:

Hi all,

Since commit d5563d7d, -c does not imply any more --no-psqlrc hence
the tests of pg_upgrade may run with a custom psqlrc file loaded. I
think that we had better add -X to avoid that, like in the patch
attached.
Thoughts?

+1

Pavel

Show quoted text

--
Michael

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

#3Tom Lane
tgl@sss.pgh.pa.us
In reply to: Michael Paquier (#1)
Re: pg_upgrade tests running calling psql without --no-psqlrc

Michael Paquier <michael.paquier@gmail.com> writes:

Since commit d5563d7d, -c does not imply any more --no-psqlrc hence
the tests of pg_upgrade may run with a custom psqlrc file loaded. I
think that we had better add -X to avoid that, like in the patch
attached.

Yeah. "grep" found a few more, but I think I got them all now.

regards, tom lane

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers