Release notes of 9.0~9.3 mentioning recovery_min_apply_delay incorrectly
Hi all,
While doing a git grep on recovery_min_apply_delay I noticed the following:
$ git grep recovery_min_apply -- *release*.sgml
src/sgml/release-9.0.sgml: that <varname>recovery_min_apply_delay</>
failed to delay application
src/sgml/release-9.1.sgml: that <varname>recovery_min_apply_delay</>
failed to delay application
src/sgml/release-9.2.sgml: that <varname>recovery_min_apply_delay</>
failed to delay application
src/sgml/release-9.3.sgml: that <varname>recovery_min_apply_delay</>
failed to delay application
src/sgml/release-9.4.sgml: Avoid busy-waiting with short
<literal>recovery_min_apply_delay</>
This is obviously incorrect because recovery_min_apply_delay has been only
introduced in 9.4. The culprit is visibly the commit message of 8049839 and
others that mentioned the parameter, though the patch applied does nothing
about it. Please see attached a patch to fix that.
Regards,
--
Michael
Attachments:
20160102_recovery_delay_releasenotes.patchtext/x-patch; charset=US-ASCII; name=20160102_recovery_delay_releasenotes.patchDownload+0-24
Michael Paquier <michael.paquier@gmail.com> writes:
This is obviously incorrect because recovery_min_apply_delay has been only
introduced in 9.4. The culprit is visibly the commit message of 8049839 and
others that mentioned the parameter, though the patch applied does nothing
about it. Please see attached a patch to fix that.
Good catch! That's on me I guess for not checking what the patch had done
in the back branches.
I didn't like simply deleting any description of the patch's effects, though.
Instead I made it talk about recovery_target_xid, which does exist in all
those branches.
regards, tom lane
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers