tab completion for CREATE USER MAPPING

Started by Fujii Masaoabout 10 years ago2 messageshackers
Jump to latest
#1Fujii Masao
masao.fujii@gmail.com

Hi,

Attached patch implements the tab-completion for CREATE USER MAPPING command.
Comments?

Regards,

--
Fujii Masao

Attachments:

tab-complete-create-user-mapping.patchtext/x-patch; charset=US-ASCII; name=tab-complete-create-user-mapping.patchDownload+8-2
#2Tom Lane
tgl@sss.pgh.pa.us
In reply to: Fujii Masao (#1)
Re: tab completion for CREATE USER MAPPING

Fujii Masao <masao.fujii@gmail.com> writes:

Attached patch implements the tab-completion for CREATE USER MAPPING command.
Comments?

I think it's really bad style to use "Query_for_list_of_users"
as the name of a query that does not in fact deliver a list of
user names, but something else with only one specialized use.
Something like "Query_for_list_of_users_plus_MAPPING" would be
less likely to trip up the unwary in future patches.

regards, tom lane

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers