Automatically add -Wold-style-definition?

Started by Andres Freundabout 10 years ago3 messageshackers
Jump to latest
#1Andres Freund
andres@anarazel.de

Hi,

Does somebody see a reason not to automatically detect and use
-Wold-style-definition? Per e.g. http://git.postgresql.org/gitweb/?p=postgresql.git;a=commitdiff;h=9f7c527af308dcdaba2f0ff9d362d672e8886fb1
that'd be useful, and it's an easy to make and automatically detect
mistake; and it doesn't have false positives.

Greetings,

Andres Freund

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

#2Tom Lane
tgl@sss.pgh.pa.us
In reply to: Andres Freund (#1)
Re: Automatically add -Wold-style-definition?

Andres Freund <andres@anarazel.de> writes:

Does somebody see a reason not to automatically detect and use
-Wold-style-definition?

+1 ... unless we have some that are that way intentionally, which
I kinda doubt, but you could soon find out.

regards, tom lane

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

#3Andres Freund
andres@anarazel.de
In reply to: Tom Lane (#2)
Re: Automatically add -Wold-style-definition?

On 2016-03-27 17:16:11 -0400, Tom Lane wrote:

Andres Freund <andres@anarazel.de> writes:

Does somebody see a reason not to automatically detect and use
-Wold-style-definition?

+1 ... unless we have some that are that way intentionally, which
I kinda doubt, but you could soon find out.

We don't, I've been running with it enabled for a long while (which is
how I found issue pointed out upthread).

Andres

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers