Small patch: --disable-setproctitle flag

Started by Aleksander Alekseevabout 10 years ago3 messageshackers
Jump to latest
#1Aleksander Alekseev
aleksander@timescale.com

Hello

Recently I discovered that renaming processes using setproctitle() call
on BSD systems may sometimes cause problems. For instance there is
currently a bug in all versions of LLDB which makes it impossible to
debug a process that called setproctitle():

https://llvm.org/bugs/show_bug.cgi?id=26924#c3

Since LLVM stack is used by default in FreeBSD I believe it's quite a
severe problem. In case there is other software that doesn't handle
stproctitle() well and for users of LLDB <= 3.8 (most recent version)
I propose to add a --disable-setproctitle flag to configure script.
Corresponding patch is attached.

--
Best regards,
Aleksander Alekseev
http://eax.me/

Attachments:

disable-setproctitle.difftext/x-patchDownload+56-2
#2Andres Freund
andres@anarazel.de
In reply to: Aleksander Alekseev (#1)
Re: Small patch: --disable-setproctitle flag

On 2016-03-31 13:06:05 +0300, Aleksander Alekseev wrote:

Hello

Recently I discovered that renaming processes using setproctitle() call
on BSD systems may sometimes cause problems. For instance there is
currently a bug in all versions of LLDB which makes it impossible to
debug a process that called setproctitle():

https://llvm.org/bugs/show_bug.cgi?id=26924#c3

Since LLVM stack is used by default in FreeBSD I believe it's quite a
severe problem. In case there is other software that doesn't handle
stproctitle() well and for users of LLDB <= 3.8 (most recent version)
I propose to add a --disable-setproctitle flag to configure script.
Corresponding patch is attached.

Seems more appropriate to simply manually add a #undef HAVE_SETPROCTITLE
to pg_config_manual.h in that case. Adding configure flags for ephemeral
debugger issues seems like a high churn activity.

Andres

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

#3Aleksander Alekseev
aleksander@timescale.com
In reply to: Andres Freund (#2)
Re: Small patch: --disable-setproctitle flag

Hello, Andres

Seems more appropriate to simply manually add a #undef
HAVE_SETPROCTITLE to pg_config_manual.h in that case. Adding
configure flags for ephemeral debugger issues seems like a high churn
activity.

I think you are right. OK.

--
Best regards,
Aleksander Alekseev
http://eax.me/

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers