pgsql: Allocate all page images at once in generic wal interface

Allocate all page images at once in generic wal interface

That reduces number of allocation.

Per gripe from Michael Paquier and Tom Lane suggestion.

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/7c979c95a3700d0bd34c2831f49a9260d505b0f9

Modified Files
--------------
src/backend/access/transam/generic_xlog.c | 19 +++++++++----------
1 file changed, 9 insertions(+), 10 deletions(-)

Seems, this patch isn't liked by curculio [1]http://pgbuildfarm.org/cgi-bin/show_log.pl?nm=curculio&dt=2016-05-17+19%3A30%3A09 -- Teodor Sigaev E-mail: teodor@sigaev.ru WWW: http://www.sigaev.ru/ buildfarm member, but I'm confused
with diagnostics:
2016-05-17 21:43:19.489 CEST [573b7457.547c:3] LOG: statement: CREATE EXTENSION
bloom;
2016-05-17 21:43:19.501 CEST [573b7457.547c:4] ERROR: syntax error in file
"/home/pgbf/buildroot/HEAD/inst/share/postgresql/extension/bloom.control" line
1, near token ""

Could somebody explain me what's going on?

Thank you

[1]: http://pgbuildfarm.org/cgi-bin/show_log.pl?nm=curculio&dt=2016-05-17+19%3A30%3A09 -- Teodor Sigaev E-mail: teodor@sigaev.ru WWW: http://www.sigaev.ru/
http://pgbuildfarm.org/cgi-bin/show_log.pl?nm=curculio&dt=2016-05-17+19%3A30%3A09
--
Teodor Sigaev E-mail: teodor@sigaev.ru
WWW: http://www.sigaev.ru/

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Teodor Sigaev <teodor@sigaev.ru> writes:

Seems, this patch isn't liked by curculio [1] buildfarm member, but I'm confused
with diagnostics:
2016-05-17 21:43:19.489 CEST [573b7457.547c:3] LOG: statement: CREATE EXTENSION
bloom;
2016-05-17 21:43:19.501 CEST [573b7457.547c:4] ERROR: syntax error in file
"/home/pgbf/buildroot/HEAD/inst/share/postgresql/extension/bloom.control" line
1, near token ""

Could somebody explain me what's going on?

That seems entirely unrelated to what you changed, and curculio's next
run failed even more bizarrely:

commands/explain.o: could not read symbols: File format not recognized
collect2: ld returned 1 exit status

It looks to me like that machine is suffering disk or filesystem
problems.

regards, tom lane

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Could somebody explain me what's going on?

That seems entirely unrelated to what you changed, and curculio's next
run failed even more bizarrely:

commands/explain.o: could not read symbols: File format not recognized
collect2: ld returned 1 exit status

As that is my animal I will take a look at it. I agree that error
message is very bizzare.

It looks to me like that machine is suffering disk or filesystem
problems.

Looks like it. I have taking it offline until I have had time to
investigate more.

/Mikael

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers