Use of CREATE OR REPLACE in bloom--1.0.sql

Started by Andreas Karlssonalmost 10 years ago2 messageshackers

andreas.karlsson@percona.com

almost 10 years ago

Hi,

I do not think that extension SQL scripts should be using CREATE OR
REPLACE FUNCTION like bloom--1.0.sql currently does. I suspect that this
might just be a typo.

I have attached the tiny patch which fixes this.

Andreas

Tom Lane

tgl@sss.pgh.pa.us

almost 10 years ago

In reply to: Andreas Karlsson (#1)

Re: Use of CREATE OR REPLACE in bloom--1.0.sql

Andreas Karlsson <andreas@proxel.se> writes:

I do not think that extension SQL scripts should be using CREATE OR
REPLACE FUNCTION like bloom--1.0.sql currently does. I suspect that this
might just be a typo.

It's definitely a bug. Grepping around found another instance in
sslinfo, and I also noticed the lack of a standard header on this
script and others. Pushed, thanks for noticing that!

regards, tom lane

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Use of CREATE OR REPLACE in bloom--1.0.sql

Attachments: