garbage in xml regress test

Started by Pavel Stehuleover 9 years ago5 messageshackers
Jump to latest
#1Pavel Stehule
pavel.stehule@gmail.com

Hi

When I checked result of xml test I found some strange lines in
expected/xml.out file

It is little bit strange - regress test reports ok, but diff is not empty

[pavel@nemesis regress]$ diff results/xml.out expected/xml.out
11a12,13

<wrong
^

63a66,67

<syntax
^

222a227,228

<invalidentity>&</invalidentity>
^

228a235,236

<undefinedentity>&idontexist;</undefinedentity>
^

246a255,256

<twoerrors>&idontexist;</unbalanced>
^

247a258,259

<twoerrors>&idontexist;</unbalanced>
^

256a269,270

^

273a288,289

<invalidentity>&</abc>
^

279a296,297

<undefinedentity>&idontexist;</abc>
^

297a316,317

<twoerrors>&idontexist;</unbalanced>
^

Regards

Pavel

#2Tom Lane
tgl@sss.pgh.pa.us
In reply to: Pavel Stehule (#1)
Re: garbage in xml regress test

Pavel Stehule <pavel.stehule@gmail.com> writes:

When I checked result of xml test I found some strange lines in
expected/xml.out file
It is little bit strange - regress test reports ok, but diff is not empty

Probably your copy of libxml produces the results in xml_2.out instead.

regards, tom lane

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

#3Pavel Stehule
pavel.stehule@gmail.com
In reply to: Tom Lane (#2)
Re: garbage in xml regress test

2016-08-07 23:16 GMT+02:00 Tom Lane <tgl@sss.pgh.pa.us>:

Pavel Stehule <pavel.stehule@gmail.com> writes:

When I checked result of xml test I found some strange lines in
expected/xml.out file
It is little bit strange - regress test reports ok, but diff is not empty

Probably your copy of libxml produces the results in xml_2.out instead.

no - it is in expected/xml.out

https://github.com/postgres/postgres/blob/master/src/test/regress/expected/xml.out

LINE 1: INSERT INTO xmltest VALUES (3, '<wrong');
^
DETAIL: line 1: Couldn't find end of Start Tag wrong line 1
<wrong
^

Regards

Pavel

Show quoted text

regards, tom lane

#4Tom Lane
tgl@sss.pgh.pa.us
In reply to: Pavel Stehule (#3)
Re: garbage in xml regress test

Pavel Stehule <pavel.stehule@gmail.com> writes:

2016-08-07 23:16 GMT+02:00 Tom Lane <tgl@sss.pgh.pa.us>:

Probably your copy of libxml produces the results in xml_2.out instead.

no - it is in expected/xml.out

No, the output you're producing is in results/xml.out, but if the
regression test harness isn't complaining about it, it's because it
matches one of the available expected/xml*.out files. Which would
be xml_2.out, looks like.

regards, tom lane

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

#5Pavel Stehule
pavel.stehule@gmail.com
In reply to: Tom Lane (#4)
Re: garbage in xml regress test

2016-08-08 5:44 GMT+02:00 Tom Lane <tgl@sss.pgh.pa.us>:

Pavel Stehule <pavel.stehule@gmail.com> writes:

2016-08-07 23:16 GMT+02:00 Tom Lane <tgl@sss.pgh.pa.us>:

Probably your copy of libxml produces the results in xml_2.out instead.

no - it is in expected/xml.out

No, the output you're producing is in results/xml.out, but if the
regression test harness isn't complaining about it, it's because it
matches one of the available expected/xml*.out files. Which would
be xml_2.out, looks like.

understand

Thank you

Pavel

Show quoted text

regards, tom lane