Tweak cost_merge_append to reflect 7a2fe9bd?

Started by Thomas Munroover 9 years ago2 messageshackers
Jump to latest
#1Thomas Munro
thomas.munro@gmail.com

Hi

As noted in a nearby review of some similar code[1]/messages/by-id/CAEepm=3o9um4pi0EphOGD7u2f862hX+BhwD5zko-TAk_Qj1JeQ@mail.gmail.com, commit 7a2fe9bd
made merge append very slightly more efficient, but nobody told
cost_merge_append about the change. I doubt it makes much difference
to the final cost in practice but I figured it might be worth
correcting the comment. Does this make sense?

[1]: /messages/by-id/CAEepm=3o9um4pi0EphOGD7u2f862hX+BhwD5zko-TAk_Qj1JeQ@mail.gmail.com

--
Thomas Munro
http://www.enterprisedb.com

Attachments:

tweak-merge-append-costing.patchapplication/octet-stream; name=tweak-merge-append-costing.patchDownload+2-3
#2Tom Lane
tgl@sss.pgh.pa.us
In reply to: Thomas Munro (#1)
Re: Tweak cost_merge_append to reflect 7a2fe9bd?

Thomas Munro <thomas.munro@enterprisedb.com> writes:

As noted in a nearby review of some similar code[1], commit 7a2fe9bd
made merge append very slightly more efficient, but nobody told
cost_merge_append about the change. I doubt it makes much difference
to the final cost in practice but I figured it might be worth
correcting the comment. Does this make sense?

Agreed, pushed.

regards, tom lane

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers