logical-replication.sgml improvements

Started by Erik Rijkersover 9 years ago4 messageshackers
Beta feature

Hackorum builds and tests every patch posted to the lists, not only commitfest submissions. This is Hackorum's own CI rather than the PostgreSQL project's, and it is still under testing - please report anything that looks wrong.

won't retrysuccessCI history

You can run a PostgreSQL built from this patch straight from Docker, with no checkout and no build:

docker run --rm -p 5432:5432 ghcr.io/hackorum-dev/postgres-patch:t35892
psql -h localhost -U postgres

Built from patchset v1 (message #1), July 28, 2026 at 08:38 AM.

Every patchset is also pushed to a branch of our PostgreSQL fork, so you can check out the same tree CI built. Without a PostgreSQL checkout:

git clone --branch t35892_1 https://github.com/hackorum-dev/postgres.git

In a checkout you already have, add the fork once:

git remote add hackorum https://github.com/hackorum-dev/postgres.git

then, for this patchset and every later one:

git fetch hackorum t35892_1 && git checkout t35892_1

Patchset v1 (message #1) is on t35892_1

Jump to latest
#1Erik Rijkers
er@xs4all.nl

logical-replication.sgml.diff changes

Erik Rijkers

Attachments:

t35892_1
logical-replication.sgml.difftext/x-diff; name=logical-replication.sgml.diffDownload+29-29
#2Robert Haas
robertmhaas@gmail.com
In reply to: Erik Rijkers (#1)
Re: logical-replication.sgml improvements

On Fri, Jan 20, 2017 at 11:00 AM, Erik Rijkers <er@xs4all.nl> wrote:

logical-replication.sgml.diff changes

I had a look at this but these are not all open-and-shut cases. In
many cases I think your proposed wording is better, but it's probably
a good idea for the people who were involved in the development of the
logical replication feature to have a look at it just to see if there
is anything with which they'd like to disagree.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

#3Erik Rijkers
er@xs4all.nl
In reply to: Robert Haas (#2)
Re: logical-replication.sgml improvements

On 2017-01-24 17:29, Robert Haas wrote:

On Fri, Jan 20, 2017 at 11:00 AM, Erik Rijkers <er@xs4all.nl> wrote:

logical-replication.sgml.diff changes

I had a look at this but these are not all open-and-shut cases. In
many cases I think your proposed wording is better, but it's probably
a good idea for the people who were involved in the development of the
logical replication feature to have a look at it just to see if there
is anything with which they'd like to disagree.

Fair enough.

I agree that most changes are arguable - it fixes really only one real
error:

    <para>
     Subscriptions are not dumped by <command>pg_dump</command> by 
default but
-   can be requested using the command-line
-   option <option>--subscriptions</option>.
+   this can be requested using the command-line
+   option <option>--include-subscriptions</option>.
    </para>

thanks,

Erik Rijkers

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

#4Peter Eisentraut
peter_e@gmx.net
In reply to: Erik Rijkers (#1)
Re: logical-replication.sgml improvements

On 1/20/17 11:00 AM, Erik Rijkers wrote:

logical-replication.sgml.diff changes

Committed, thanks!

--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers