logical-replication.sgml improvements

Started by Erik Rijkersabout 9 years ago4 messageshackers
Jump to latest
#1Erik Rijkers
er@xs4all.nl

logical-replication.sgml.diff changes

Erik Rijkers

Attachments:

logical-replication.sgml.difftext/x-diff; name=logical-replication.sgml.diffDownload+29-29
#2Robert Haas
robertmhaas@gmail.com
In reply to: Erik Rijkers (#1)
Re: logical-replication.sgml improvements

On Fri, Jan 20, 2017 at 11:00 AM, Erik Rijkers <er@xs4all.nl> wrote:

logical-replication.sgml.diff changes

I had a look at this but these are not all open-and-shut cases. In
many cases I think your proposed wording is better, but it's probably
a good idea for the people who were involved in the development of the
logical replication feature to have a look at it just to see if there
is anything with which they'd like to disagree.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

#3Erik Rijkers
er@xs4all.nl
In reply to: Robert Haas (#2)
Re: logical-replication.sgml improvements

On 2017-01-24 17:29, Robert Haas wrote:

On Fri, Jan 20, 2017 at 11:00 AM, Erik Rijkers <er@xs4all.nl> wrote:

logical-replication.sgml.diff changes

I had a look at this but these are not all open-and-shut cases. In
many cases I think your proposed wording is better, but it's probably
a good idea for the people who were involved in the development of the
logical replication feature to have a look at it just to see if there
is anything with which they'd like to disagree.

Fair enough.

I agree that most changes are arguable - it fixes really only one real
error:

    <para>
     Subscriptions are not dumped by <command>pg_dump</command> by 
default but
-   can be requested using the command-line
-   option <option>--subscriptions</option>.
+   this can be requested using the command-line
+   option <option>--include-subscriptions</option>.
    </para>

thanks,

Erik Rijkers

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

#4Peter Eisentraut
peter_e@gmx.net
In reply to: Erik Rijkers (#1)
Re: logical-replication.sgml improvements

On 1/20/17 11:00 AM, Erik Rijkers wrote:

logical-replication.sgml.diff changes

Committed, thanks!

--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers