pgsql: Reindent table partitioning code.
Reindent table partitioning code.
We've accumulated quite a bit of stuff with which pgindent is not
quite happy in this code; clean it up to provide a less-annoying base
for future pgindent runs.
Branch
------
master
Details
-------
http://git.postgresql.org/pg/commitdiff/27cdb3414b3fb4c8fcc069572568390450bb04c9
Modified Files
--------------
src/backend/catalog/heap.c | 40 +++++++++++++++---------------
src/backend/catalog/partition.c | 22 ++++++++---------
src/backend/commands/copy.c | 19 +++++++-------
src/backend/commands/trigger.c | 2 +-
src/backend/executor/execMain.c | 24 +++++++++---------
src/backend/executor/nodeModifyTable.c | 45 +++++++++++++++++-----------------
src/backend/utils/adt/ruleutils.c | 30 +++++++++++------------
src/include/catalog/heap.h | 12 ++++-----
src/include/catalog/indexing.h | 2 +-
src/include/catalog/partition.h | 28 ++++++++++-----------
src/include/catalog/pg_class.h | 2 +-
src/include/catalog/pg_proc.h | 2 +-
src/include/commands/defrem.h | 2 +-
src/include/nodes/parsenodes.h | 20 +++++++--------
src/include/utils/rel.h | 10 ++++----
15 files changed, 130 insertions(+), 130 deletions(-)
--
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers
Robert Haas <rhaas@postgresql.org> writes:
Reindent table partitioning code.
Oh, thank you, I was starting to get annoyed with that too.
regards, tom lane
--
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers
On Tue, Jan 24, 2017 at 10:28 AM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
Robert Haas <rhaas@postgresql.org> writes:
Reindent table partitioning code.
Oh, thank you, I was starting to get annoyed with that too.
Glad you like. The pgindent damage introduced by the logical
replication commits is even more extensive, but I didn't want to touch
that without discussion. Peter might want to look for a time when not
too many patches are pending to do something similar, though.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
On 1/24/17 10:51 AM, Robert Haas wrote:
On Tue, Jan 24, 2017 at 10:28 AM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
Robert Haas <rhaas@postgresql.org> writes:
Reindent table partitioning code.
Oh, thank you, I was starting to get annoyed with that too.
Glad you like. The pgindent damage introduced by the logical
replication commits is even more extensive, but I didn't want to touch
that without discussion. Peter might want to look for a time when not
too many patches are pending to do something similar, though.
Can you give me an example of a file or area that looks bad now?
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
On Thu, Jan 26, 2017 at 10:16 AM, Peter Eisentraut
<peter.eisentraut@2ndquadrant.com> wrote:
On 1/24/17 10:51 AM, Robert Haas wrote:
On Tue, Jan 24, 2017 at 10:28 AM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
Robert Haas <rhaas@postgresql.org> writes:
Reindent table partitioning code.
Oh, thank you, I was starting to get annoyed with that too.
Glad you like. The pgindent damage introduced by the logical
replication commits is even more extensive, but I didn't want to touch
that without discussion. Peter might want to look for a time when not
too many patches are pending to do something similar, though.Can you give me an example of a file or area that looks bad now?
What I did was just run pgindent on the whole tree and then undid all
the stuff that was unrelated to table partitioning with 'git checkout'
and/or 'git checkout -p'.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers