simplify sequence test

Started by Peter Eisentrautover 9 years ago3 messageshackers
Beta feature

Hackorum builds and tests every patch posted to the lists, not only commitfest submissions. This is Hackorum's own CI rather than the PostgreSQL project's, and it is still under testing - please report anything that looks wrong.

won't retrysuccessCI history

You can run a PostgreSQL built from this patch straight from Docker, with no checkout and no build:

docker run --rm -p 5432:5432 ghcr.io/hackorum-dev/postgres-patch:t35919
psql -h localhost -U postgres

Built from patchset v1 (message #1), July 28, 2026 at 08:33 AM.

Every patchset is also pushed to a branch of our PostgreSQL fork, so you can check out the same tree CI built. Without a PostgreSQL checkout:

git clone --branch t35919_1 https://github.com/hackorum-dev/postgres.git

In a checkout you already have, add the fork once:

git remote add hackorum https://github.com/hackorum-dev/postgres.git

then, for this patchset and every later one:

git fetch hackorum t35919_1 && git checkout t35919_1

Patchset v1 (message #1) is on t35919_1

Jump to latest
#1Peter Eisentraut
peter_e@gmx.net

We maintain a separate test output file sequence_1.out because the
log_cnt value can vary if there is a checkpoint happening at the right
time. So we have to maintain two files because of a one character
difference. I propose the attached patch to restructure the test a bit
to avoid this, without loss of test coverage.

--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Attachments:

t35919_1
0001-Simplify-sequence-test.patchtext/x-patch; name=0001-Simplify-sequence-test.patchDownload+9-478
#2Petr Jelinek
petr@2ndquadrant.com
In reply to: Peter Eisentraut (#1)
Re: simplify sequence test

On 25/01/17 03:48, Peter Eisentraut wrote:

We maintain a separate test output file sequence_1.out because the
log_cnt value can vary if there is a checkpoint happening at the right
time. So we have to maintain two files because of a one character
difference. I propose the attached patch to restructure the test a bit
to avoid this, without loss of test coverage.

+1, looks good.

--
Petr Jelinek http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

#3Peter Eisentraut
peter_e@gmx.net
In reply to: Petr Jelinek (#2)
Re: simplify sequence test

On 1/25/17 5:29 AM, Petr Jelinek wrote:

On 25/01/17 03:48, Peter Eisentraut wrote:

We maintain a separate test output file sequence_1.out because the
log_cnt value can vary if there is a checkpoint happening at the right
time. So we have to maintain two files because of a one character
difference. I propose the attached patch to restructure the test a bit
to avoid this, without loss of test coverage.

+1, looks good.

committed

--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers