[PATCH] Add tab completion for DEALLOCATE

Started by Dagfinn Ilmari Mannsåkerover 9 years ago5 messageshackers
Beta feature

Hackorum builds and tests every patch posted to the lists, not only commitfest submissions. This is Hackorum's own CI rather than the PostgreSQL project's, and it is still under testing - please report anything that looks wrong.

won't retrytests failedCI history

You can run a PostgreSQL built from this patch straight from Docker, with no checkout and no build:

docker run --rm -p 5432:5432 ghcr.io/hackorum-dev/postgres-patch:t35951
psql -h localhost -U postgres

Built from patchset v3 (message #3), July 28, 2026 at 08:28 AM.

Every patchset is also pushed to a branch of our PostgreSQL fork, so you can check out the same tree CI built. Without a PostgreSQL checkout:

git clone --branch t35951_3 https://github.com/hackorum-dev/postgres.git

In a checkout you already have, add the fork once:

git remote add hackorum https://github.com/hackorum-dev/postgres.git

then, for this patchset and every later one:

git fetch hackorum t35951_3 && git checkout t35951_3

Patchset v3 (message #3) is on t35951_3

Jump to latest

Hi hackers,

While playing with prepared statements in psql, I noticed that EXECUTE
tab-completes the list of active prepared statements, but DEALLOCATE
does not.

Attached is a patch to fix this.

Cheers,

Ilmari

--
"I use RMS as a guide in the same way that a boat captain would use
a lighthouse. It's good to know where it is, but you generally
don't want to find yourself in the same spot." - Tollef Fog Heen

Attachments:

0001-Add-tab-completion-for-DEALLOCATE.patchtext/x-diffDownload+2-3
#2Tom Lane
tgl@sss.pgh.pa.us
In reply to: Dagfinn Ilmari Mannsåker (#1)
Re: [PATCH] Add tab completion for DEALLOCATE

ilmari@ilmari.org (Dagfinn Ilmari =?utf-8?Q?Manns=C3=A5ker?=) writes:

While playing with prepared statements in psql, I noticed that EXECUTE
tab-completes the list of active prepared statements, but DEALLOCATE
does not.
Attached is a patch to fix this.

Good idea, but I think it would be better to give DEALLOCATE its own
entry in the list, so it could be placed in alphabetical order.

regards, tom lane

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

In reply to: Tom Lane (#2)
Re: [PATCH] Add tab completion for DEALLOCATE

Tom Lane <tgl@sss.pgh.pa.us> writes:

ilmari@ilmari.org (Dagfinn Ilmari =?utf-8?Q?Manns=C3=A5ker?=) writes:

While playing with prepared statements in psql, I noticed that EXECUTE
tab-completes the list of active prepared statements, but DEALLOCATE
does not.
Attached is a patch to fix this.

Good idea, but I think it would be better to give DEALLOCATE its own
entry in the list, so it could be placed in alphabetical order.

I was following the example from FETCH/MOVE further down to avoid
duplicating the body of the stanza, but I guess in this case it's simple
enough that it doesn't matter.

Here's an updated patch wich adds it as a separate stanza.

--
- Twitter seems more influential [than blogs] in the 'gets reported in
the mainstream press' sense at least. - Matt McLeod
- That'd be because the content of a tweet is easier to condense down
to a mainstream media article. - Calle Dybedahl

Attachments:

t35951_3
0001-Add-tab-completion-for-DEALLOCATE.patchtext/x-diffDownload+4-1
In reply to: Dagfinn Ilmari Mannsåker (#3)
Re: [PATCH] Add tab completion for DEALLOCATE

ilmari@ilmari.org (Dagfinn Ilmari Manns�ker) writes:

Here's an updated patch wich adds it as a separate stanza.

I've added this to the current commit fest:
https://commitfest.postgresql.org/13/1043/

--
"I use RMS as a guide in the same way that a boat captain would use
a lighthouse. It's good to know where it is, but you generally
don't want to find yourself in the same spot." - Tollef Fog Heen

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

#5Peter Eisentraut
peter_e@gmx.net
In reply to: Dagfinn Ilmari Mannsåker (#4)
Re: [PATCH] Add tab completion for DEALLOCATE

On 2/27/17 06:34, Dagfinn Ilmari Mannsåker wrote:

ilmari@ilmari.org (Dagfinn Ilmari Manns�ker) writes:

Here's an updated patch wich adds it as a separate stanza.

I've added this to the current commit fest:
https://commitfest.postgresql.org/13/1043/

committed

--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers