pgsql: Remove all references to "xlog" from SQL-callable functions in p
Remove all references to "xlog" from SQL-callable functions in pg_proc.
Commit f82ec32ac30ae7e3ec7c84067192535b2ff8ec0e renamed the pg_xlog
directory to pg_wal. To make things consistent, and because "xlog" is
terrible terminology for either "transaction log" or "write-ahead log"
rename all SQL-callable functions that contain "xlog" in the name to
instead contain "wal". (Note that this may pose an upgrade hazard for
some users.)
Similarly, rename the xlog_position argument of the functions that
create slots to be called wal_position.
Discussion: /messages/by-id/CA+Tgmob=YmA=H3DbW1YuOXnFVgBheRmyDkWcD9M8f=5bGWYEoQ@mail.gmail.com
Branch
------
master
Details
-------
http://git.postgresql.org/pg/commitdiff/806091c96f9b81f7631e4e37a05af377b473b5da
Modified Files
--------------
contrib/bloom/t/001_wal.pl | 2 +-
contrib/test_decoding/expected/ddl.out | 2 +-
contrib/test_decoding/sql/ddl.sql | 2 +-
doc/src/sgml/backup.sgml | 2 +-
doc/src/sgml/func.sgml | 72 +++++++++++-----------
doc/src/sgml/high-availability.sgml | 14 ++---
doc/src/sgml/logicaldecoding.sgml | 2 +-
doc/src/sgml/recovery-config.sgml | 2 +-
src/backend/access/transam/recovery.conf.sample | 2 +-
src/backend/access/transam/xlog.c | 2 +-
src/backend/access/transam/xlogfuncs.c | 36 +++++------
src/backend/catalog/system_views.sql | 10 +--
src/bin/pg_basebackup/t/030_pg_recvlogical.pl | 2 +-
src/bin/pg_rewind/RewindTest.pm | 2 +-
src/bin/pg_rewind/libpq_fetch.c | 4 +-
src/include/catalog/catversion.h | 2 +-
src/include/catalog/pg_proc.h | 54 ++++++++--------
src/test/modules/commit_ts/t/002_standby.pl | 8 +--
src/test/modules/commit_ts/t/003_standby_2.pl | 4 +-
src/test/perl/PostgresNode.pm | 10 +--
src/test/recovery/t/002_archiving.pl | 6 +-
src/test/recovery/t/003_recovery_targets.pl | 16 ++---
src/test/recovery/t/005_replay_delay.pl | 4 +-
src/test/recovery/t/008_fsm_truncation.pl | 4 +-
src/test/regress/expected/hs_standby_functions.out | 2 +-
src/test/regress/sql/hs_primary_extremes.sql | 2 +-
src/test/regress/sql/hs_primary_setup.sql | 2 +-
src/test/regress/sql/hs_standby_functions.sql | 2 +-
src/test/subscription/t/001_rep_changes.pl | 2 +-
src/test/subscription/t/002_types.pl | 2 +-
30 files changed, 138 insertions(+), 138 deletions(-)
--
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers
On Fri, Feb 10, 2017 at 5:36 AM, Robert Haas <rhaas@postgresql.org> wrote:
Remove all references to "xlog" from SQL-callable functions in pg_proc.
Commit f82ec32ac30ae7e3ec7c84067192535b2ff8ec0e renamed the pg_xlog
directory to pg_wal. To make things consistent, and because "xlog" is
terrible terminology for either "transaction log" or "write-ahead log"
rename all SQL-callable functions that contain "xlog" in the name to
instead contain "wal". (Note that this may pose an upgrade hazard for
some users.)
There are still some mentions to "xlog" in the doc. Maybe we should replace
them with "wal" as the attached patch does.
Regards,
--
Fujii Masao
Attachments:
xlog2wal.patchapplication/octet-stream; name=xlog2wal.patchDownload+8-8
On Mon, Feb 13, 2017 at 11:43 AM, Fujii Masao <masao.fujii@gmail.com> wrote:
On Fri, Feb 10, 2017 at 5:36 AM, Robert Haas <rhaas@postgresql.org> wrote:
Remove all references to "xlog" from SQL-callable functions in pg_proc.
Commit f82ec32ac30ae7e3ec7c84067192535b2ff8ec0e renamed the pg_xlog
directory to pg_wal. To make things consistent, and because "xlog" is
terrible terminology for either "transaction log" or "write-ahead log"
rename all SQL-callable functions that contain "xlog" in the name to
instead contain "wal". (Note that this may pose an upgrade hazard for
some users.)There are still some mentions to "xlog" in the doc. Maybe we should replace
them with "wal" as the attached patch does.
+1. Patch looks good to me.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
On Tue, Feb 14, 2017 at 2:06 AM, Robert Haas <robertmhaas@gmail.com> wrote:
On Mon, Feb 13, 2017 at 11:43 AM, Fujii Masao <masao.fujii@gmail.com> wrote:
On Fri, Feb 10, 2017 at 5:36 AM, Robert Haas <rhaas@postgresql.org> wrote:
Remove all references to "xlog" from SQL-callable functions in pg_proc.
Commit f82ec32ac30ae7e3ec7c84067192535b2ff8ec0e renamed the pg_xlog
directory to pg_wal. To make things consistent, and because "xlog" is
terrible terminology for either "transaction log" or "write-ahead log"
rename all SQL-callable functions that contain "xlog" in the name to
instead contain "wal". (Note that this may pose an upgrade hazard for
some users.)There are still some mentions to "xlog" in the doc. Maybe we should replace
them with "wal" as the attached patch does.+1. Patch looks good to me.
Thanks! Pushed.
Regards,
--
Fujii Masao
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
On Tue, Feb 14, 2017 at 2:31 AM, Fujii Masao <masao.fujii@gmail.com> wrote:
On Tue, Feb 14, 2017 at 2:06 AM, Robert Haas <robertmhaas@gmail.com> wrote:
On Mon, Feb 13, 2017 at 11:43 AM, Fujii Masao <masao.fujii@gmail.com> wrote:
On Fri, Feb 10, 2017 at 5:36 AM, Robert Haas <rhaas@postgresql.org> wrote:
Remove all references to "xlog" from SQL-callable functions in pg_proc.
Commit f82ec32ac30ae7e3ec7c84067192535b2ff8ec0e renamed the pg_xlog
directory to pg_wal. To make things consistent, and because "xlog" is
terrible terminology for either "transaction log" or "write-ahead log"
rename all SQL-callable functions that contain "xlog" in the name to
instead contain "wal". (Note that this may pose an upgrade hazard for
some users.)There are still some mentions to "xlog" in the doc. Maybe we should replace
them with "wal" as the attached patch does.+1. Patch looks good to me.
Thanks! Pushed.
It seems like the previous review I provided for the set of renaming
patches has been ignored:
/messages/by-id/CAB7nPqSm=PNSe3EfvnEResdFzpQMcXXgapFBcF=EFdxVW4=fDQ@mail.gmail.com
Good that somebody else checked...
--
Michael
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
On Mon, Feb 13, 2017 at 5:00 PM, Michael Paquier
<michael.paquier@gmail.com> wrote:
It seems like the previous review I provided for the set of renaming
patches has been ignored:
/messages/by-id/CAB7nPqSm=PNSe3EfvnEResdFzpQMcXXgapFBcF=EFdxVW4=fDQ@mail.gmail.com
Good that somebody else checked...
Sorry about that, Michael. That was careless of me.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
On Wed, Feb 15, 2017 at 2:08 AM, Robert Haas <robertmhaas@gmail.com> wrote:
On Mon, Feb 13, 2017 at 5:00 PM, Michael Paquier
<michael.paquier@gmail.com> wrote:It seems like the previous review I provided for the set of renaming
patches has been ignored:
/messages/by-id/CAB7nPqSm=PNSe3EfvnEResdFzpQMcXXgapFBcF=EFdxVW4=fDQ@mail.gmail.com
Good that somebody else checked...Sorry about that, Michael. That was careless of me.
No problem. Thanks.
--
Michael
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers