duplicate "median" entry in doc

Started by Fabien COELHOabout 9 years ago6 messageshackers
Jump to latest
#1Fabien COELHO
coelho@cri.ensmp.fr

When trying to build the documentation there is a minor warning:

collateindex.pl: duplicated index entry found: MEDIAN

Indeed, the "median" index term is specified twice in "syntax.sgml". The
attached patch removes the warning.

--
Fabien.

Attachments:

doc-median.patchtext/x-diff; name=doc-median.patchDownload+0-3
#2Tom Lane
tgl@sss.pgh.pa.us
In reply to: Fabien COELHO (#1)
Re: duplicate "median" entry in doc

Fabien COELHO <coelho@cri.ensmp.fr> writes:

When trying to build the documentation there is a minor warning:
collateindex.pl: duplicated index entry found: MEDIAN

See
/messages/by-id/29262.1483053514@sss.pgh.pa.us

I've been waiting for some clarification on that before attempting
to fix this. In any case, your proposed patch would remove the main
index entry, which doesn't seem like what we want.

regards, tom lane

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

#3Fabien COELHO
coelho@cri.ensmp.fr
In reply to: Tom Lane (#2)
Re: duplicate "median" entry in doc

When trying to build the documentation there is a minor warning:
collateindex.pl: duplicated index entry found: MEDIAN

See
/messages/by-id/29262.1483053514@sss.pgh.pa.us

I've been waiting for some clarification on that before attempting
to fix this. In any case, your proposed patch would remove the main
index entry, which doesn't seem like what we want.

Hmmm. I do not get it.

I confirm that "oldhtml" does not generate the "see also" in head,
probably because the first termindex/primary is kept and overrides the
second somehow, which is consistent with the warning.

However, after removing the duplicate, both "oldhtml" (openjade 1.3,
issues with 1.4) and "html" (xsltproc) generate a correct "median" index
with its "see also" subsection, in "bookindex.html":

...
MD5, Password Authentication
median, Aggregate Expressions
(see also percentile)
memory context
...

So this really seems ok to me... The only difference is that with the new
chain the percentile is a link and there are parentheses, while with
oldhtml it is just text.

Am I missing something?

--
Fabien.

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

#4Tom Lane
tgl@sss.pgh.pa.us
In reply to: Fabien COELHO (#3)
Re: duplicate "median" entry in doc

Fabien COELHO <coelho@cri.ensmp.fr> writes:

I confirm that "oldhtml" does not generate the "see also" in head,
probably because the first termindex/primary is kept and overrides the
second somehow, which is consistent with the warning.

However, after removing the duplicate, both "oldhtml" (openjade 1.3,
issues with 1.4) and "html" (xsltproc) generate a correct "median" index
with its "see also" subsection, in "bookindex.html":

[ scratches head... ] Coulda sworn I tried that and it didn't do what
I wanted. But testing now, it does, so pushed. Thanks for pointing
out my error.

regards, tom lane

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

#5Fabien COELHO
coelho@cri.ensmp.fr
In reply to: Tom Lane (#4)
Re: duplicate "median" entry in doc

[ scratches head... ]

Magic:-)

While testing with "oldhtml" I found that the "maintainer-clean" targets
in "sgml" does not clean enough: it lacks cleaning the "oldhtml-stamp".

See attached very minor fix.

--
Fabien.

Attachments:

doc-cleaner.patchtext/x-diff; name=doc-cleaner.patchDownload+1-1
#6Tom Lane
tgl@sss.pgh.pa.us
In reply to: Fabien COELHO (#5)
oldhtml-stamp (was Re: duplicate "median" entry in doc)

Fabien COELHO <coelho@cri.ensmp.fr> writes:

While testing with "oldhtml" I found that the "maintainer-clean" targets
in "sgml" does not clean enough: it lacks cleaning the "oldhtml-stamp".

Yeah, and .gitignore fails to ignore it, too. I'm not sure if it's
worth fixing ... Peter, what's the expected half-life of the "oldhtml"
target?

regards, tom lane

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers