remove deprecated COMMENT ON RULE syntax

Started by Peter Eisentrautover 9 years ago3 messageshackers
Beta feature

Hackorum builds and tests every patch posted to the lists, not only commitfest submissions. This is Hackorum's own CI rather than the PostgreSQL project's, and it is still under testing - please report anything that looks wrong.

won't retrysuccessCI history

You can run a PostgreSQL built from this patch straight from Docker, with no checkout and no build:

docker run --rm -p 5432:5432 ghcr.io/hackorum-dev/postgres-patch:t36101
psql -h localhost -U postgres

Built from patchset v1 (message #1), July 28, 2026 at 08:08 AM.

Every patchset is also pushed to a branch of our PostgreSQL fork, so you can check out the same tree CI built. Without a PostgreSQL checkout:

git clone --branch t36101_1 https://github.com/hackorum-dev/postgres.git

In a checkout you already have, add the fork once:

git remote add hackorum https://github.com/hackorum-dev/postgres.git

then, for this patchset and every later one:

git fetch hackorum t36101_1 && git checkout t36101_1

Patchset v1 (message #1) is on t36101_1

Jump to latest
#1Peter Eisentraut
peter_e@gmx.net

There is support for COMMENT ON RULE <name> without specifying a table
name, for upgrading from pre-7.3 instances. I think it might be time
for that workaround to go.

Patch attached.

--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Attachments:

t36101_1
0001-Remove-deprecated-COMMENT-ON-RULE-syntax.patchtext/x-patch; name=0001-Remove-deprecated-COMMENT-ON-RULE-syntax.patchDownload+53-149
#2Tom Lane
tgl@sss.pgh.pa.us
In reply to: Peter Eisentraut (#1)
Re: remove deprecated COMMENT ON RULE syntax

Peter Eisentraut <peter.eisentraut@2ndquadrant.com> writes:

There is support for COMMENT ON RULE <name> without specifying a table
name, for upgrading from pre-7.3 instances. I think it might be time
for that workaround to go.

No objection here.

regards, tom lane

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

#3Robert Haas
robertmhaas@gmail.com
In reply to: Tom Lane (#2)
Re: remove deprecated COMMENT ON RULE syntax

On Wed, Feb 22, 2017 at 8:05 PM, Tom Lane <tgl@sss.pgh.pa.us> wrote:

Peter Eisentraut <peter.eisentraut@2ndquadrant.com> writes:

There is support for COMMENT ON RULE <name> without specifying a table
name, for upgrading from pre-7.3 instances. I think it might be time
for that workaround to go.

No objection here.

Yeah, probably so.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers