A typo in mcxt.c
Hackorum builds and tests every patch posted to the lists, not only commitfest submissions. This is Hackorum's own CI rather than the PostgreSQL project's, and it is still under testing - please report anything that looks wrong.
You can run a PostgreSQL built from this patch straight from Docker, with no checkout and no build:
docker run --rm -p 5432:5432 ghcr.io/hackorum-dev/postgres-patch:t36111psql -h localhost -U postgresBuilt from patchset v1 (message #1), September 20, 2026 at 01:13 PM.
Every patchset is also pushed to a branch of our PostgreSQL fork, so you can check out the same tree CI built. Without a PostgreSQL checkout:
git clone --branch t36111_1 https://github.com/hackorum-dev/postgres.gitIn a checkout you already have, add the fork once:
git remote add hackorum https://github.com/hackorum-dev/postgres.gitthen, for this patchset and every later one:
git fetch hackorum t36111_1 && git checkout t36111_1Patchset v1 (message #1) is on t36111_1
Hello, while I investigated a bug of async-exec patch. I found a
(maybe) typo in mcxt.c.
| * It's not entirely clear whether 'tis better to do this before or after
| * delinking the context; but an error in a callback will likely result in
I'm not so confident, but the "'tis" seems to me to be a typo of
"it's".
regards
--
Kyotaro Horiguchi
NTT Open Source Software Center
On Thu, Feb 23, 2017 at 5:40 PM, Kyotaro HORIGUCHI
<horiguchi.kyotaro@lab.ntt.co.jp> wrote:
Hello, while I investigated a bug of async-exec patch. I found a
(maybe) typo in mcxt.c.| * It's not entirely clear whether 'tis better to do this before or after
| * delinking the context; but an error in a callback will likely result inI'm not so confident, but the "'tis" seems to me to be a typo of
"it's".
That is an archaic way of contracting the same words differently:
https://en.wiktionary.org/wiki/'tis
It sounds amusing and a tiny bit like a famous line from Hamlet,
"Whether 'tis nobler in the mind to suffer...".
https://en.wikipedia.org/wiki/To_be,_or_not_to_be
--
Thomas Munro
http://www.enterprisedb.com
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
On 2/23/17 6:38 AM, Thomas Munro wrote:
I'm not so confident, but the "'tis" seems to me to be a typo of
"it's".That is an archaic way of contracting the same words differently:
Given the number of non-native English speakers we have, it's probably
worth changing it...
--
Jim Nasby, Data Architect, Blue Treble Consulting, Austin TX
Experts in Analytics, Data Architecture and PostgreSQL
Data in Trouble? Get it in Treble! http://BlueTreble.com
855-TREBLE2 (855-873-2532)
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
On 2017-02-23 14:26:07 -0600, Jim Nasby wrote:
On 2/23/17 6:38 AM, Thomas Munro wrote:
I'm not so confident, but the "'tis" seems to me to be a typo of
"it's".That is an archaic way of contracting the same words differently:
Given the number of non-native English speakers we have, it's probably worth
changing it...
I'm a non-native speaker and I actually like discovering new language
"features" every now and then. I think as long as it's not inhibiting
understanding to much - which doesn't seem to be the case here - it's
fine to keep things like this.
- Andres
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
Andres Freund <andres@anarazel.de> writes:
On 2017-02-23 14:26:07 -0600, Jim Nasby wrote:
On 2/23/17 6:38 AM, Thomas Munro wrote:
That is an archaic way of contracting the same words differently:
Given the number of non-native English speakers we have, it's probably worth
changing it...
I'm a non-native speaker and I actually like discovering new language
"features" every now and then. I think as long as it's not inhibiting
understanding to much - which doesn't seem to be the case here - it's
fine to keep things like this.
While I don't recall it specifically, git blame says that comment is mine.
I'm pretty sure it's not a typo, but that the allusion to Hamlet was
intentional. I think it's good to have a bit of levity and external
references in our comments; cuts down on the boredom of reading totally
dry code.
(But see commit d2783bee3 for one hazard of this sort of thing.)
regards, tom lane
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
I'm happy to know such a thing. mcxt.c is very stable part of the
code so those who don't know such things like me rarely comes.
At Thu, 23 Feb 2017 22:59:51 -0500, Tom Lane <tgl@sss.pgh.pa.us> wrote in <31880.1487908791@sss.pgh.pa.us>
Andres Freund <andres@anarazel.de> writes:
On 2017-02-23 14:26:07 -0600, Jim Nasby wrote:
On 2/23/17 6:38 AM, Thomas Munro wrote:
That is an archaic way of contracting the same words differently:
Given the number of non-native English speakers we have, it's probably worth
changing it...I'm a non-native speaker and I actually like discovering new language
"features" every now and then. I think as long as it's not inhibiting
understanding to much - which doesn't seem to be the case here - it's
fine to keep things like this.While I don't recall it specifically, git blame says that comment is mine.
I'm pretty sure it's not a typo, but that the allusion to Hamlet was
intentional. I think it's good to have a bit of levity and external
references in our comments; cuts down on the boredom of reading totally
dry code.(But see commit d2783bee3 for one hazard of this sort of thing.)
regards, tom lane
--
Kyotaro Horiguchi
NTT Open Source Software Center
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers