pgsql: Throw an error if a DATA() line contains wrong # of attributes.

Started by Robert Haasabout 9 years ago3 messageshackers
Jump to latest
#1Robert Haas
robertmhaas@gmail.com

Throw an error if a DATA() line contains wrong # of attributes.

David Christensen, reviewed by Dagfinn Ilmari Mannsåker

Discussion: /messages/by-id/20170215154018.fs5vwtqhp5d2sifs@veeddeux.attlocal.net

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/7666e73a2e9e0e91a9f3b246a4299b44daadcbf8

Modified Files
--------------
src/backend/catalog/Catalog.pm | 28 +++++++++++++++++++++++++++-
1 file changed, 27 insertions(+), 1 deletion(-)

--
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers

#2Michael Paquier
michael@paquier.xyz
In reply to: Robert Haas (#1)
Re: [COMMITTERS] pgsql: Throw an error if a DATA() line contains wrong # of attributes.

On Fri, Mar 10, 2017 at 8:20 AM, Robert Haas <rhaas@postgresql.org> wrote:

Throw an error if a DATA() line contains wrong # of attributes.

David Christensen, reviewed by Dagfinn Ilmari Mannsåker

Discussion: /messages/by-id/20170215154018.fs5vwtqhp5d2sifs@veeddeux.attlocal.net

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/7666e73a2e9e0e91a9f3b246a4299b44daadcbf8

dromedary is unhappy because of this commit, and it is using perl 5.10.0:
https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=dromedary&amp;dt=2017-03-10%2000%3A03%3A34

Here are the details:
Can't locate object method "input_line_number" via package
"IO::Handle" at ../../../src/backend/catalog/Catalog.pm line 82,
<INPUT_FILE> line 148.
Can't locate object method "input_line_number" via package
"IO::Handle" at ../../../src/backend/catalog/Catalog.pm line 82,
<INPUT_FILE> line 148.
--
Michael

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

#3Tom Lane
tgl@sss.pgh.pa.us
In reply to: Michael Paquier (#2)
Re: Re: [COMMITTERS] pgsql: Throw an error if a DATA() line contains wrong # of attributes.

Michael Paquier <michael.paquier@gmail.com> writes:

On Fri, Mar 10, 2017 at 8:20 AM, Robert Haas <rhaas@postgresql.org> wrote:

Throw an error if a DATA() line contains wrong # of attributes.

dromedary is unhappy because of this commit, and it is using perl 5.10.0:

My RHEL6 workstation (5.10.1) is also completely broken by this. Kindly
revert so I can get some work done.

regards, tom lane

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers