createlang/droplang deprecated

2017-03-18 14:00 GMT+01:00 Peter Eisentraut <
peter.eisentraut@2ndquadrant.com>:

I just noticed that createlang and droplang have been listed as
deprecated since PG 9.1.

Do we dare remove them?

+1

Pavel

On Sat, Mar 18, 2017 at 3:09 PM, Pavel Stehule <pavel.stehule@gmail.com>
wrote:

2017-03-18 14:00 GMT+01:00 Peter Eisentraut <peter.eisentraut@2ndquadrant.
com>:

I just noticed that createlang and droplang have been listed as
deprecated since PG 9.1.

Do we dare remove them?

+1

+1.

(I'd extend it to all the non-prefixed pg binaries, but let's open that can
of worms right now, one thing at a time)

--
Magnus Hagander
Me: http://www.hagander.net/
Work: http://www.redpill-linpro.com/

Magnus Hagander <magnus@hagander.net> writes:

2017-03-18 14:00 GMT+01:00 Peter Eisentraut <peter.eisentraut@2ndquadrant.com>:

I just noticed that createlang and droplang have been listed as
deprecated since PG 9.1.
Do we dare remove them?

(I'd extend it to all the non-prefixed pg binaries, but let's open that can
of worms right now, one thing at a time)

To my mind, these two and createuser/dropuser are the only really serious
namespacing problems among our standard binaries. The ones with names
ending in "db" don't seem likely to cause huge confusion. I suppose that
if we were naming it today, "psql" wouldn't get that name; but the chances
of renaming that one are certainly zero, namespace conflict or no.

But createuser/dropuser are a real problem, because they certainly could
be mistaken for system-level utilities.

regards, tom lane

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

On Sat, Mar 18, 2017 at 11:29 AM, Tom Lane <tgl@sss.pgh.pa.us> wrote:

Magnus Hagander <magnus@hagander.net> writes:

2017-03-18 14:00 GMT+01:00 Peter Eisentraut <peter.eisentraut@2ndquadrant.com>:

I just noticed that createlang and droplang have been listed as
deprecated since PG 9.1.
Do we dare remove them?

(I'd extend it to all the non-prefixed pg binaries, but let's open that can
of worms right now, one thing at a time)

To my mind, these two and createuser/dropuser are the only really serious
namespacing problems among our standard binaries. The ones with names
ending in "db" don't seem likely to cause huge confusion. I suppose that
if we were naming it today, "psql" wouldn't get that name; but the chances
of renaming that one are certainly zero, namespace conflict or no.

But createuser/dropuser are a real problem, because they certainly could
be mistaken for system-level utilities.

Well, let's do one thing at a time. I think it'd be fine to drop
createlang and droplang; we can discuss other things on other threads.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

On Sat, Mar 18, 2017 at 6:13 PM, Robert Haas <robertmhaas@gmail.com> wrote:

On Sat, Mar 18, 2017 at 11:29 AM, Tom Lane <tgl@sss.pgh.pa.us> wrote:

Magnus Hagander <magnus@hagander.net> writes:

2017-03-18 14:00 GMT+01:00 Peter Eisentraut <

peter.eisentraut@2ndquadrant.com>:

I just noticed that createlang and droplang have been listed as
deprecated since PG 9.1.
Do we dare remove them?

(I'd extend it to all the non-prefixed pg binaries, but let's open that

can

of worms right now, one thing at a time)

To my mind, these two and createuser/dropuser are the only really serious
namespacing problems among our standard binaries. The ones with names
ending in "db" don't seem likely to cause huge confusion. I suppose that
if we were naming it today, "psql" wouldn't get that name; but the

chances

of renaming that one are certainly zero, namespace conflict or no.

But createuser/dropuser are a real problem, because they certainly could
be mistaken for system-level utilities.

Well, let's do one thing at a time. I think it'd be fine to drop
createlang and droplang; we can discuss other things on other threads.

+1. I see no issues at all dropping createlang/droplang, so let's do that.
Some of the others can be worth discussing, so let's not wait for that to
pan out before these are removed.

--
Magnus Hagander
Me: http://www.hagander.net/
Work: http://www.redpill-linpro.com/

On 3/18/17 9:00 AM, Peter Eisentraut wrote:

I just noticed that createlang and droplang have been listed as
deprecated since PG 9.1.

Do we dare remove them?

+1

--
-David
david@pgmasters.net

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

On 3/18/17 09:00, Peter Eisentraut wrote:

I just noticed that createlang and droplang have been listed as
deprecated since PG 9.1.

Do we dare remove them?

Patch

--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

On Mon, Mar 20, 2017 at 1:37 AM, Peter Eisentraut <
peter.eisentraut@2ndquadrant.com> wrote:

On 3/18/17 09:00, Peter Eisentraut wrote:

I just noticed that createlang and droplang have been listed as
deprecated since PG 9.1.

Do we dare remove them?

Patch

+1

--
Magnus Hagander
Me: http://www.hagander.net/
Work: http://www.redpill-linpro.com/

On 20 Mar 2017, at 01:37, Peter Eisentraut <peter.eisentraut@2ndquadrant.com> wrote:

On 3/18/17 09:00, Peter Eisentraut wrote:

I just noticed that createlang and droplang have been listed as
deprecated since PG 9.1.

Do we dare remove them?

Patch

LGTM, +1

cheers ./daniel

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

On 3/23/17 06:41, Daniel Gustafsson wrote:

On 20 Mar 2017, at 01:37, Peter Eisentraut <peter.eisentraut@2ndquadrant.com> wrote:

On 3/18/17 09:00, Peter Eisentraut wrote:

I just noticed that createlang and droplang have been listed as
deprecated since PG 9.1.

Do we dare remove them?

Patch

LGTM, +1

Committed.

--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

2017-03-18 12:29 GMT-03:00 Tom Lane <tgl@sss.pgh.pa.us>:

But createuser/dropuser are a real problem, because they certainly could
be mistaken for system-level utilities.

I proposed something along those lines [1]/messages/by-id/bdd1adb1-c26d-ad1f-2f15-cc52056065d4@timbira.com.br to fix this historical mistake
but we didn't reach a consensus. createuser/dropuser could be a candidate
to removal because it is easily replaced by psql -c "command here" like
Simon said. If we go to this road, other binaries (that are just a wrapper
around an SQL command) could be removed too (such as createdb, dropdb,
clusterdb and reindexdb).

[1]: /messages/by-id/bdd1adb1-c26d-ad1f-2f15-cc52056065d4@timbira.com.br
/messages/by-id/bdd1adb1-c26d-ad1f-2f15-cc52056065d4@timbira.com.br

--
Euler Taveira Timbira -
http://www.timbira.com.br/
PostgreSQL: Consultoria, Desenvolvimento, Suporte 24x7 e Treinamento
<http://www.timbira.com.br&gt;