Compilation warning with MSVC in pg_depend.c

Started by Michael Paquierover 9 years ago2 messageshackers
Beta feature

Hackorum builds and tests every patch posted to the lists, not only commitfest submissions. This is Hackorum's own CI rather than the PostgreSQL project's, and it is still under testing - please report anything that looks wrong.

won't retrytests failedCI history

You can run a PostgreSQL built from this patch straight from Docker, with no checkout and no build:

docker run --rm -p 5432:5432 ghcr.io/hackorum-dev/postgres-patch:t36441
psql -h localhost -U postgres

Built from patchset v1 (message #1), July 28, 2026 at 07:23 AM.

Every patchset is also pushed to a branch of our PostgreSQL fork, so you can check out the same tree CI built. Without a PostgreSQL checkout:

git clone --branch t36441_1 https://github.com/hackorum-dev/postgres.git

In a checkout you already have, add the fork once:

git remote add hackorum https://github.com/hackorum-dev/postgres.git

then, for this patchset and every later one:

git fetch hackorum t36441_1 && git checkout t36441_1

Patchset v1 (message #1) is on t36441_1

Jump to latest
#1Michael Paquier
michael@paquier.xyz

Hi all,

I am getting the following warning with MSVC 2010 for what is a result
of 3217327 (identity columns):
c:\users\michael\git\postgres\src\backend\catalog\pg_depend.c(615):
warning C4715: 'getOwnedSequence' : not all control paths return a
value [C:\Users\michael\git\postgres\postgres.vcxproj]

I agree that this compiler is dumb after looking at the code, but
could it be possible to silence this warning with something like the
attached?

Thanks,
--
Michael
VMware vCenter Server
www.vmware.com

Attachments:

t36441_1
seq-msvc-warning.patchapplication/octet-stream; name=seq-msvc-warning.patchDownload+2-2
#2Peter Eisentraut
peter_e@gmx.net
In reply to: Michael Paquier (#1)
Re: Compilation warning with MSVC in pg_depend.c

On 4/6/17 23:03, Michael Paquier wrote:

Hi all,

I am getting the following warning with MSVC 2010 for what is a result
of 3217327 (identity columns):
c:\users\michael\git\postgres\src\backend\catalog\pg_depend.c(615):
warning C4715: 'getOwnedSequence' : not all control paths return a
value [C:\Users\michael\git\postgres\postgres.vcxproj]

I agree that this compiler is dumb after looking at the code, but
could it be possible to silence this warning with something like the
attached?

fixed

--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers