Make defines in pg_config_manual.h conditional?

Started by Andres Freundabout 9 years ago2 messageshackers
Jump to latest
#1Andres Freund
andres@anarazel.de

Hi,

ATM the defines in pg_config_manual.h are largely unconditional - which
means the file has to be edited instead of being able to override things
via CFLAGS/COPT. Is there any good reason for doing so?

Greetings,

Andres Freund

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

#2Tom Lane
tgl@sss.pgh.pa.us
In reply to: Andres Freund (#1)
Re: Make defines in pg_config_manual.h conditional?

Andres Freund <andres@anarazel.de> writes:

ATM the defines in pg_config_manual.h are largely unconditional - which
means the file has to be edited instead of being able to override things
via CFLAGS/COPT. Is there any good reason for doing so?

YES. If you do things like that, the installed version of
pg_config_manual.h will not reflect the way the backend was built,
which is likely to break pgxs-type builds of addon modules later.

Just edit the file.

regards, tom lane

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers