Re: [SQL] RE: [GENERAL] Problem with SELECT on large negative INT4

Bruce Momjian <pgman@candle.pha.pa.us> writes:

Could you try the follwoing patch ?

Hiroshi, I don't see this in the main tree, nor do I see it having been
requested for application. Should I apply it?

If this does fix things, I would venture that the blame really belongs
to whatever caller of the comparison function is failing to interpret
the return value correctly ...

BTW there is a somewhat-related issue that has been bothering me:
the system is pretty erratic about converting between Datum and bool.
Some places use "DatumGetInt32(datum) != 0" as their effective test
for whether a Datum value is "true", some places use
"DatumGetInt8(datum) != 0", some places just do "(bool) datum", and
there may be other variants.

I am thinking of introducing DatumGetBool and BoolGetDatum macros and
trying to make the code use those uniformly, but there's a lot of code
to clean up. I was intending to do it during the function manager
interface rewrite, since all these same places will need to be looked
at for that.

Perhaps we should also try to clean up btree's sort comparison functions
in the same way, with some macros that provide a well-defined conversion
between Datum and the "<", "=", ">" return conditions that are intended.

regards, tom lane

From bouncefilter Thu Jan 27 12:55:16 2000
Received: from candle.pha.pa.us (pgman@s5-03.ppp.op.net [209.152.195.67])
by hub.org (8.9.3/8.9.3) with ESMTP id MAA25788
for <pgsql-hackers@postgreSQL.org>;
Thu, 27 Jan 2000 12:55:10 -0500 (EST)
(envelope-from pgman@candle.pha.pa.us)
Received: (from pgman@localhost) by candle.pha.pa.us (8.9.0/8.9.0) id
MAA26087;
Thu, 27 Jan 2000 12:52:43 -0500 (EST)
From: Bruce Momjian <pgman@candle.pha.pa.us>
Message-Id: <200001271752.MAA26087@candle.pha.pa.us>
Subject: Re: [HACKERS] Column ADDing issues
In-Reply-To: <Pine.LNX.4.21.0001262020480.416-100000@localhost.localdomain>
from Peter Eisentraut at "Jan 27, 2000 06:41:45 pm"
To: Peter Eisentraut <peter_e@gmx.net>
Date: Thu, 27 Jan 2000 12:52:43 -0500 (EST)
CC: Tom Lane <tgl@sss.pgh.pa.us>,
PostgreSQL Development <pgsql-hackers@postgreSQL.org>
X-Mailer: ELM [version 2.4ME+ PL66 (25)]
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

I suggest you be very cautious about messing with ALTER TABLE until you
understand why inheritance makes it such a headache ;-)

I'm just trying to get the defaults and constraints working. If
inheritance stays broken the way it previously was, it's beyond my
powers. But I get the feeling that people rather not alter their tables
unless they have *perfect* alter table commands. I don't feel like arguing
with them, they'll just have to do without then.

OK, so am I hearing we don't want ALTER TABLE DROP COLUMN without it
working for inhertance. Is this really the way we want things? May as
well disable ADD COLUMN too because that doesn't work for inheritance
either.

-- 
  Bruce Momjian                        |  http://www.op.net/~candle
  pgman@candle.pha.pa.us               |  (610) 853-3000
  +  If your life is a hard drive,     |  830 Blythe Avenue
  +  Christ can be your backup.        |  Drexel Hill, Pennsylvania 19026

From bouncefilter Thu Jan 27 13:05:18 2000
Received: from thelab.hub.org (nat202.87.mpoweredpc.net [142.177.202.87])
by hub.org (8.9.3/8.9.3) with ESMTP id NAA31405;
Thu, 27 Jan 2000 13:05:02 -0500 (EST) (envelope-from scrappy@hub.org)
Received: from localhost (scrappy@localhost)
by thelab.hub.org (8.9.3/8.9.1) with ESMTP id OAA23020;
Thu, 27 Jan 2000 14:05:00 -0400 (AST) (envelope-from scrappy@hub.org)
X-Authentication-Warning: thelab.hub.org: scrappy owned process doing -bs
Date: Thu, 27 Jan 2000 14:05:00 -0400 (AST)
From: The Hermit Hacker <scrappy@hub.org>
To: Michael Meskes <meskes@postgreSQL.org>
cc: PostgreSQL Hacker <pgsql-hackers@postgreSQL.org>
Subject: Re: [HACKERS] CVS problem
In-Reply-To: <20000127131930.A2455@fam-meskes.de>
Message-ID: <Pine.BSF.4.21.0001271404350.555-100000@thelab.hub.org>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII

fixed ... FreeBSD changed /etc/services to use 'cvspserver' instead of
'cvs', and inetd.conf had 'cvs' still ... tested from my home machine and
all appears to work ...

On Thu, 27 Jan 2000, Michael Meskes wrote:

On Thu, Jan 27, 2000 at 02:42:26AM -0500, Tom Lane wrote:

It's not your problem --- the CVS server seems to have been down
for the last several hours...

I see. Thanks.

Michael
--
Michael Meskes | Go SF 49ers!
Th.-Heuss-Str. 61, D-41812 Erkelenz | Go Rhein Fire!
Tel.: (+49) 2431/72651 | Use Debian GNU/Linux!
Email: Michael@Fam-Meskes.De | Use PostgreSQL!

************

Marc G. Fournier ICQ#7615664 IRC Nick: Scrappy
Systems Administrator @ hub.org
primary: scrappy@hub.org secondary: scrappy@{freebsd|postgresql}.org