Incorrect use of ERRCODE_UNDEFINED_COLUMN in extended stats

Started by David Rowleyalmost 9 years ago4 messageshackers
Jump to latest
#1David Rowley
dgrowleyml@gmail.com

The attached small patched fixes an incorrect usage of an error code
in the extended stats code.

--
David Rowley http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services

Attachments:

ext_stats_duplicate_column_errorcode_fix.patchapplication/octet-stream; name=ext_stats_duplicate_column_errorcode_fix.patchDownload+1-1
#2Alvaro Herrera
alvherre@2ndquadrant.com
In reply to: David Rowley (#1)
Re: Incorrect use of ERRCODE_UNDEFINED_COLUMN in extended stats

David Rowley wrote:

The attached small patched fixes an incorrect usage of an error code
in the extended stats code.

Thanks for the report. I'm on vacation starting today until May 2nd.
If nobody commits this in the meantime, I'll get to it when I'm back.

--
�lvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

#3Tom Lane
tgl@sss.pgh.pa.us
In reply to: David Rowley (#1)
Re: Incorrect use of ERRCODE_UNDEFINED_COLUMN in extended stats

David Rowley <david.rowley@2ndquadrant.com> writes:

The attached small patched fixes an incorrect usage of an error code
in the extended stats code.

Hmm, looks like all of that could do with an editorial pass (e.g.,
"duplicity" does not mean what the comments author seems to think).

regards, tom lane

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

#4David Rowley
dgrowleyml@gmail.com
In reply to: Tom Lane (#3)
Re: Incorrect use of ERRCODE_UNDEFINED_COLUMN in extended stats

On 25 April 2017 at 02:15, Tom Lane <tgl@sss.pgh.pa.us> wrote:

David Rowley <david.rowley@2ndquadrant.com> writes:

The attached small patched fixes an incorrect usage of an error code
in the extended stats code.

Hmm, looks like all of that could do with an editorial pass (e.g.,
"duplicity" does not mean what the comments author seems to think).

Was about to look at this, but see you've beaten me to it.

Thanks for committing and for fixing the other stuff too.

--
David Rowley http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers