Making replication commands case-insensitive
Hackorum builds and tests every patch posted to the lists, not only commitfest submissions. This is Hackorum's own CI rather than the PostgreSQL project's, and it is still under testing - please report anything that looks wrong.
You can run a PostgreSQL built from this patch straight from Docker, with no checkout and no build:
docker run --rm -p 5432:5432 ghcr.io/hackorum-dev/postgres-patch:t36740psql -h localhost -U postgresBuilt from patchset v1 (message #1), July 28, 2026 at 06:40 AM.
Every patchset is also pushed to a branch of our PostgreSQL fork, so you can check out the same tree CI built. Without a PostgreSQL checkout:
git clone --branch t36740_1 https://github.com/hackorum-dev/postgres.gitIn a checkout you already have, add the fork once:
git remote add hackorum https://github.com/hackorum-dev/postgres.gitthen, for this patchset and every later one:
git fetch hackorum t36740_1 && git checkout t36740_1Patchset v1 (message #1) is on t36740_1
Hi all,
$subject has been raised in a recent thread here:
/messages/by-id/CAB7nPqTmym5t-X6hvMF_P-KRc=ndXtbQCTiU=NhS_jvL7x1kCA@mail.gmail.com
The idea is to make the replication protocol a bit more flexible, in a
way similar to what 5c837dd has done, but for repl_scanner.l. This
will also allow to avoid any problems like what has been fixed in
aa41bc7 where the SHOW commands used in libpq have to be capitalized.
Personally, I have pested about the lack of flexibility a couple of
times when running tests using psql..
I am parking that in the next CF.
Thanks,
--
Michael
On Sat, May 20, 2017 at 2:19 PM, Michael Paquier <michael.paquier@gmail.com>
wrote:
Hi all,
$subject has been raised in a recent thread here:
/messages/by-id/CAB7nPqTmym5t-
X6hvMF_P-KRc=ndXtbQCTiU=NhS_jvL7x1kCA@mail.gmail.comThe idea is to make the replication protocol a bit more flexible, in a
way similar to what 5c837dd has done, but for repl_scanner.l. This
will also allow to avoid any problems like what has been fixed in
aa41bc7 where the SHOW commands used in libpq have to be capitalized.
Personally, I have pested about the lack of flexibility a couple of
times when running tests using psql..I am parking that in the next CF.
Given that the protocol really isn't intended for "manual consumption", do
we really want that? Not that it adds a lot of complexity, but still. It
certainly makes the code completely unreadable. And since any program using
it should figure out pretty quickly that it's not working if they us the
wrong casing...
--
Magnus Hagander
Me: https://www.hagander.net/ <http://www.hagander.net/>
Work: https://www.redpill-linpro.com/ <http://www.redpill-linpro.com/>
Hi,
On 2017-05-20 21:19:10 +0900, Michael Paquier wrote:
$subject has been raised in a recent thread here:
/messages/by-id/CAB7nPqTmym5t-X6hvMF_P-KRc=ndXtbQCTiU=NhS_jvL7x1kCA@mail.gmail.comThe idea is to make the replication protocol a bit more flexible, in a
way similar to what 5c837dd has done, but for repl_scanner.l. This
will also allow to avoid any problems like what has been fixed in
aa41bc7 where the SHOW commands used in libpq have to be capitalized.
Personally, I have pested about the lack of flexibility a couple of
times when running tests using psql..
-1. This solution is too bad for maintainability, and given the
replication protocol is not for interactive use I don't see a
corresponding benefit.
Greetings,
Andres Freund
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers