Re: src/test/locale/de_DE.ISO-8859-1

Started by Bruce Momjianalmost 26 years ago5 messages
#1Bruce Momjian
pgman@candle.pha.pa.us

Hello!

On Mon, 27 Mar 2000, Bruce Momjian wrote:

Sorry for bothering you again. The thing is fixed in beta3
distribution of March 24, but in snapshot of March 26 it is again tar file,
not a directory. Seems there are two different mechanisms fot betas and
snapshots. Should I be afraid of snapshots or just use betas?

Seems Tom has found the cause. Now we need Marc to fix it with his
permissions on the directory.

While we are at this, could I ask you to do some renaming in the CVS
repository? I did some mistakes, my pardons, and now, when people send more
and more locale tests, these errors become more important.

In the directory src/test/locale two directories should be renamed:
ISO8859-7 should be named gr_GR.ISO8859-7
de_DE.ISO-8859-1 should be renamed to de_DE.ISO8859-1

What about symlinks there? Can you add symlink ru_RU.KOI8-R pointing to
the directory koi8-r? I don't want to rename directory koi8-r 'cause there
is koi8-to-win1251 that contains the multibyte cyrillic tests.

Gee, it is pretty late in beta to be doing this. Comments?

-- 
  Bruce Momjian                        |  http://www.op.net/~candle
  pgman@candle.pha.pa.us               |  (610) 853-3000
  +  If your life is a hard drive,     |  830 Blythe Avenue
  +  Christ can be your backup.        |  Drexel Hill, Pennsylvania 19026
#2Bruce Momjian
pgman@candle.pha.pa.us
In reply to: Bruce Momjian (#1)

On Sun, 2 Apr 2000, Bruce Momjian wrote:

While we are at this, could I ask you to do some renaming in the CVS
repository? I did some mistakes, my pardons, and now, when people send more
and more locale tests, these errors become more important.

In the directory src/test/locale two directories should be renamed:
ISO8859-7 should be named gr_GR.ISO8859-7
de_DE.ISO-8859-1 should be renamed to de_DE.ISO8859-1

What about symlinks there? Can you add symlink ru_RU.KOI8-R pointing to
the directory koi8-r? I don't want to rename directory koi8-r 'cause there
is koi8-to-win1251 that contains the multibyte cyrillic tests.

Gee, it is pretty late in beta to be doing this. Comments?

I am not in hurry. I just want to understand is it at all possible, esp.
symlinks. I am not sure how well CVS goes with symlinks.
But month after month I'll collect locale tests from people, so at any
rate I'll need more consistent scheme.

No idea, but I would hope it would work.

-- 
  Bruce Momjian                        |  http://www.op.net/~candle
  pgman@candle.pha.pa.us               |  (610) 853-3000
  +  If your life is a hard drive,     |  830 Blythe Avenue
  +  Christ can be your backup.        |  Drexel Hill, Pennsylvania 19026
#3The Hermit Hacker
scrappy@hub.org
In reply to: Bruce Momjian (#2)
Re: AW: src/test/locale/de_DE.ISO-8859-1

Is this something that is safe to do just before a release like this? If
so, I'll do it ... if not, someone remind me right afer the release ..

On Mon, 3 Apr 2000, Zeugswetter Andreas SB wrote:

In the directory src/test/locale two directories should

be renamed:

ISO8859-7 should be named gr_GR.ISO8859-7
de_DE.ISO-8859-1 should be renamed to de_DE.ISO8859-1

The rename from de_DE.ISO-8859-1 to de_DE.ISO8859-1 sounds reasonable,
since that is the correct name, the prior is bogus. The only other wording I
know does exist
somewhere is de_DE.8859-1 .

The reason why this was undetected is probably because most de_DE
installations
will probably not use --enable-locale.

Andreas

Marc G. Fournier ICQ#7615664 IRC Nick: Scrappy
Systems Administrator @ hub.org
primary: scrappy@hub.org secondary: scrappy@{freebsd|postgresql}.org

#4Tom Lane
tgl@sss.pgh.pa.us
In reply to: The Hermit Hacker (#3)
Re: AW: src/test/locale/de_DE.ISO-8859-1

The Hermit Hacker <scrappy@hub.org> writes:

Is this something that is safe to do just before a release like this? If
so, I'll do it ... if not, someone remind me right afer the release ..

Don't see what's dangerous about it. The absolute worst case,
if Andreas is mistaken, is that the locale-specific tests stop
working for these locales. But I believe what he's asserting
is that they're broken already ... so how could you be making
it worse?

regards, tom lane

#5The Hermit Hacker
scrappy@hub.org
In reply to: Tom Lane (#4)
Re: AW: src/test/locale/de_DE.ISO-8859-1

Done, please test to confirm ...

On Mon, 3 Apr 2000, Oleg Broytmann wrote:

On Mon, 3 Apr 2000, The Hermit Hacker wrote:

Is this something that is safe to do just before a release like this?

In the directory src/test/locale two directories should

be renamed:

ISO8859-7 should be named gr_GR.ISO8859-7
de_DE.ISO-8859-1 should be renamed to de_DE.ISO8859-1

I don't see any problem here. Locale tests are completely separated from
backend; changes in the tests will not affect postgres in any way.

Oleg.
----
Oleg Broytmann http://members.xoom.com/phd2.1/ phd2@earthling.net
Programmers don't die, they just GOSUB without RETURN.

Marc G. Fournier ICQ#7615664 IRC Nick: Scrappy
Systems Administrator @ hub.org
primary: scrappy@hub.org secondary: scrappy@{freebsd|postgresql}.org