pgsql: Fix bug that can cause walsender not to terminating at shutdown.

Started by Andres Freundover 8 years ago3 messageshackers
Jump to latest
#1Andres Freund
andres@anarazel.de

Fix bug that can cause walsender not to terminating at shutdown.

When backpatching c6c333436 I (Andres Freund) mis-resolved a conflict
in the 9.4 branch. Unfortunately that leads to walsenders waiting
forever when shutting down with connected standbys, unless immediate
mode is used, or the standbys are forced to disconnect by other means.

Author: Marco Nenciarini
Reported-By: Abhijit Gharami, Marco Nenciarini
Discussion:
/messages/by-id/1434ad79-ab0d-d6a9-4ea2-1afb1c06adaf@2ndquadrant.it
/messages/by-id/CAA5_DuD0O1XyM8OnOzhRepyPU-t8nZKLzs1pT2JpzP0NS+vVNA@mail.gmail.com
Backpatch: 9.4 only

Branch
------
REL9_4_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/b51c8efc6aff292912d8e77235eae8eef7ec909c

Modified Files
--------------
src/backend/replication/walsender.c | 1 +
1 file changed, 1 insertion(+)

--
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers

#2Alvaro Herrera
alvherre@2ndquadrant.com
In reply to: Andres Freund (#1)
Re: [COMMITTERS] pgsql: Fix bug that can cause walsender not to terminating at shutdown.

Andres Freund wrote:

Fix bug that can cause walsender not to terminating at shutdown.

When backpatching c6c333436 I (Andres Freund) mis-resolved a conflict
in the 9.4 branch. Unfortunately that leads to walsenders waiting
forever when shutting down with connected standbys, unless immediate
mode is used, or the standbys are forced to disconnect by other means.

Hmm, I think we should issue a new 9.4 release with this bug fix.

--
�lvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

#3Michael Paquier
michael@paquier.xyz
In reply to: Alvaro Herrera (#2)
Re: Re: [COMMITTERS] pgsql: Fix bug that can cause walsender not to terminating at shutdown.

On Fri, Aug 25, 2017 at 3:36 PM, Alvaro Herrera
<alvherre@2ndquadrant.com> wrote:

Andres Freund wrote:

Fix bug that can cause walsender not to terminating at shutdown.

When backpatching c6c333436 I (Andres Freund) mis-resolved a conflict
in the 9.4 branch. Unfortunately that leads to walsenders waiting
forever when shutting down with connected standbys, unless immediate
mode is used, or the standbys are forced to disconnect by other means.

Hmm, I think we should issue a new 9.4 release with this bug fix.

+1.
-- 
Michael

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers