multiple target of VACUUM command

On Thu, Aug 31, 2017 at 9:53 PM, Kyotaro HORIGUCHI
<horiguchi.kyotaro@lab.ntt.co.jp> wrote:

I sometimes feel annoyed when trying to VACUUM multiple specific
tables.

postgres=# vacuum a, b;
ERROR: syntax error at or near ","
LINE 1: vacuum a, b;

This patch just allows multiple targets for VACUUM command.

There is a patch for the same feature by Nathan Bossart which is being
discussed already in this commit fest:
/messages/by-id/E061A8E3-5E3D-494D-94F0-E8A9B312BBFC@amazon.com
It had already a couple of rounds of reviews, and is getting close to
something that could be committed. There is still a pending bug
related to the use of RangeVar though with autovacuum.

Your approach is missing a couple of points. For example when
specifying multiple targets, we have decided to check for an ERROR at
the beginning of VACUUM, but we are issuing a WARNING if it goes
missing in the middle of processing a list, so your set of patches
would provide a frustrating experience. We have also discussed about
reshaping a bit the API of vacuum(), so I would recommend looking at
what has been already proposed if you are interested.
--
Michael

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Ouch!

At Thu, 31 Aug 2017 23:09:20 +0900, Michael Paquier <michael.paquier@gmail.com> wrote in <CAB7nPqSB0k1ZyeXJ8iHdMQbeksYKB-psbiBvEfn--rTNmTreBw@mail.gmail.com>

On Thu, Aug 31, 2017 at 9:53 PM, Kyotaro HORIGUCHI
<horiguchi.kyotaro@lab.ntt.co.jp> wrote:

I sometimes feel annoyed when trying to VACUUM multiple specific
tables.

postgres=# vacuum a, b;
ERROR: syntax error at or near ","
LINE 1: vacuum a, b;

This patch just allows multiple targets for VACUUM command.

There is a patch for the same feature by Nathan Bossart which is being
discussed already in this commit fest:
/messages/by-id/E061A8E3-5E3D-494D-94F0-E8A9B312BBFC@amazon.com

Sorry for the duplication.

It had already a couple of rounds of reviews, and is getting close to
something that could be committed. There is still a pending bug
related to the use of RangeVar though with autovacuum.

Your approach is missing a couple of points. For example when
specifying multiple targets, we have decided to check for an ERROR at
the beginning of VACUUM, but we are issuing a WARNING if it goes
missing in the middle of processing a list, so your set of patches
would provide a frustrating experience. We have also discussed about
reshaping a bit the API of vacuum(), so I would recommend looking at
what has been already proposed if you are interested.

Thank you! I'll do that. I've mark this as "Rejected".

regards,

--
Kyotaro Horiguchi
NTT Open Source Software Center

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers