Inconsistencies between pg_settings and postgresql.conf

Started by Adrian Escomsover 8 years ago5 messageshackers
Jump to latest
#1Adrian Escoms
adescoms@ongres.com

Hello,

We are working with postgresql.conf configuration file and we have found
some discrepancies between it and pg_settings in terms of categories and
subcategories (we have split the field category in pg_settings by '/', the
first part being 'category', the second 'subcategory')
We suggest to change the postgresql.conf.sample file with the attached diff
to resolve these inconsistencies.
We think that these changes could also be backported to previous versions.

Looking forward to your comments,

Adrián Escoms

Attachments:

postgresql.conf.sample.difftext/plain; charset=US-ASCII; name=postgresql.conf.sample.diffDownload+13-12
#2Adrian Escoms
adescoms@ongres.com
In reply to: Adrian Escoms (#1)
Re: Inconsistencies between pg_settings and postgresql.conf

Hi,

I realized that the parameter 'shared_preload_libraries' used to belong to
category 'Resource Usage / Kernel Resources' but since postgresql version
9.4 it was changed in pg_settings to 'Client Connection Defaults / Shared
Library Preloading' but in postgresql.conf it remains unchanged.
I attach the updated postgresql.conf.sample.diff with this change.

Regards

Adrián Escoms

On Wed, Sep 13, 2017 at 11:51 AM, Adrian Escoms <adescoms@ongres.com> wrote:

Show quoted text

Hello,

We are working with postgresql.conf configuration file and we have found
some discrepancies between it and pg_settings in terms of categories and
subcategories (we have split the field category in pg_settings by '/', the
first part being 'category', the second 'subcategory')
We suggest to change the postgresql.conf.sample file with the attached
diff to resolve these inconsistencies.
We think that these changes could also be backported to previous
versions.

Looking forward to your comments,

Adrián Escoms

Attachments:

postgresql.conf.sample.difftext/plain; charset=US-ASCII; name=postgresql.conf.sample.diffDownload+19-15
#3Robert Haas
robertmhaas@gmail.com
In reply to: Adrian Escoms (#2)
Re: [HACKERS] Inconsistencies between pg_settings and postgresql.conf

On Wed, Sep 13, 2017 at 11:50 AM, Adrian Escoms <adescoms@ongres.com> wrote:

I realized that the parameter 'shared_preload_libraries' used to belong to
category 'Resource Usage / Kernel Resources' but since postgresql version
9.4 it was changed in pg_settings to 'Client Connection Defaults / Shared
Library Preloading' but in postgresql.conf it remains unchanged.
I attach the updated postgresql.conf.sample.diff with this change.

I think this is a good idea, except I'd leave out this hunk:

@@ -105,7 +105,7 @@

 #------------------------------------------------------------------------------
-# RESOURCE USAGE (except WAL)
+# RESOURCE USAGE
 #------------------------------------------------------------------------------

# - Memory -

I think a parenthetical gloss is a little different than different
text, and not out of place in what is after all a sample file intended
to be read by humans.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

#4Adrian Escoms
adescoms@ongres.com
In reply to: Robert Haas (#3)
Re: [HACKERS] Inconsistencies between pg_settings and postgresql.conf

Hi,

It makes sense, so I attach the new diff without these lines.
Thank you,

Regards

Adrián Escoms

On Wed, Nov 15, 2017 at 10:30 PM, Robert Haas <robertmhaas@gmail.com> wrote:

Show quoted text

On Wed, Sep 13, 2017 at 11:50 AM, Adrian Escoms <adescoms@ongres.com>
wrote:

I realized that the parameter 'shared_preload_libraries' used to belong

to

category 'Resource Usage / Kernel Resources' but since postgresql version
9.4 it was changed in pg_settings to 'Client Connection Defaults / Shared
Library Preloading' but in postgresql.conf it remains unchanged.
I attach the updated postgresql.conf.sample.diff with this change.

I think this is a good idea, except I'd leave out this hunk:

@@ -105,7 +105,7 @@

#-----------------------------------------------------------
-------------------
-# RESOURCE USAGE (except WAL)
+# RESOURCE USAGE
#-----------------------------------------------------------
-------------------

# - Memory -

I think a parenthetical gloss is a little different than different
text, and not out of place in what is after all a sample file intended
to be read by humans.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Attachments:

postgresql.conf.sample.difftext/plain; charset=US-ASCII; name=postgresql.conf.sample.diffDownload+18-14
#5Robert Haas
robertmhaas@gmail.com
In reply to: Adrian Escoms (#4)
Re: [HACKERS] Inconsistencies between pg_settings and postgresql.conf

On Thu, Nov 16, 2017 at 6:08 AM, Adrian Escoms <adescoms@ongres.com> wrote:

It makes sense, so I attach the new diff without these lines.

Thanks. Committed.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company