CI
Applieswon't retry9y behind master
Buildsuccess1m 45s / 2m 26s
Tests452 / 452
GitHub runGitHub branchCI history
Participants
Jesper Pedersen
Jesper Pedersen
Peter Eisentraut
Peter Eisentraut
Attachments
Download Latest Patchset
+1-2
Show all attachments
Show all patchsets
Thread Outline
#1Jesper PedersenJesper Pedersen
Sep 28, 2017
#2Peter Eisentraut↳Peter Eisentrautto Jesper Pedersen (#1)
Nov 02, 2017

initdb w/ restart

Started by Jesper Pedersenalmost 9 years ago2 messageshackers
Beta feature

Hackorum builds and tests every patch posted to the lists, not only commitfest submissions. This is Hackorum's own CI rather than the PostgreSQL project's, and it is still under testing - please report anything that looks wrong.

won't retrysuccessCI history

You can run a PostgreSQL built from this patch straight from Docker, with no checkout and no build:

docker run --rm -p 5432:5432 ghcr.io/hackorum-dev/postgres-patch:t37491
psql -h localhost -U postgres

Built from patchset v1 (message #1), July 27, 2026 at 10:08 PM.

Every patchset is also pushed to a branch of our PostgreSQL fork, so you can check out the same tree CI built. Without a PostgreSQL checkout:

git clone --branch t37491_1 https://github.com/hackorum-dev/postgres.git

In a checkout you already have, add the fork once:

git remote add hackorum https://github.com/hackorum-dev/postgres.git

then, for this patchset and every later one:

git fetch hackorum t37491_1 && git checkout t37491_1

Patchset v1 (message #1) is on t37491_1

Jump to latest
#1Jesper Pedersen
Jesper Pedersen
jesper.pedersen@redhat.com

Hi,

In a case of

initdb /tmp/pgsql

followed by

pg_ctl -D /tmp/pgsql/ -l /tmp/logfile restart

you'll get

pg_ctl: PID file "/tmp/pgsql/postmaster.pid" does not exist
Is server running?
starting server anyway
pg_ctl: could not read file "/tmp/pgsql/postmaster.opts"

The attached patch changes the message to "trying to start server
anyway" to highlight it is an attempt, not something that will happen.

Probably not a good idea to change the logic around pg_ctl.c:688, hence
this suggestion.

Thoughts ?

Best regards,
Jesper

Attachments:

t37491_1
0001-Change-message-for-restarting-a-server-from-a-direct.patchtext/x-patch; name=0001-Change-message-for-restarting-a-server-from-a-direct.patchDownload+1-2
#2Peter Eisentraut
Peter Eisentraut
peter_e@gmx.net
In reply to: Jesper Pedersen (#1)
Re: initdb w/ restart

On 9/28/17 15:40, Jesper Pedersen wrote:

In a case of

initdb /tmp/pgsql

followed by

pg_ctl -D /tmp/pgsql/ -l /tmp/logfile restart

you'll get

pg_ctl: PID file "/tmp/pgsql/postmaster.pid" does not exist
Is server running?
starting server anyway
pg_ctl: could not read file "/tmp/pgsql/postmaster.opts"

The attached patch changes the message to "trying to start server
anyway" to highlight it is an attempt, not something that will happen.

committed

--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

← Back to Topics