Combining expr{Type,Typmod,Collation}() into one function.

Started by Andres Freundalmost 9 years ago1 messageshackers
Beta feature

Hackorum builds and tests every patch posted to the lists, not only commitfest submissions. This is Hackorum's own CI rather than the PostgreSQL project's, and it is still under testing - please report anything that looks wrong.

won't retrysuccessCI history

You can run a PostgreSQL built from this patch straight from Docker, with no checkout and no build:

docker run --rm -p 5432:5432 ghcr.io/hackorum-dev/postgres-patch:t37513
psql -h localhost -U postgres

Built from patchset v1 (message #1), July 27, 2026 at 10:07 PM.

Every patchset is also pushed to a branch of our PostgreSQL fork, so you can check out the same tree CI built. Without a PostgreSQL checkout:

git clone --branch t37513_1 https://github.com/hackorum-dev/postgres.git

In a checkout you already have, add the fork once:

git remote add hackorum https://github.com/hackorum-dev/postgres.git

then, for this patchset and every later one:

git fetch hackorum t37513_1 && git checkout t37513_1

Patchset v1 (message #1) is on t37513_1

Jump to latest
#1Andres Freund
andres@anarazel.de

Hi,

I'd recently noticed that expr* functions actually show up in profiles
because we use them at some very common paths
(e.g. ExecTypeFromTLInternal()) and that we commonly call all the three
variants from $subject in sequence.

Looking at their code I was wondering whether it's reasonable to combine
them into one function. The performance effects in my case were
neglegible, but it might still be worth it just to reduce duplication.

I've attached my *WIP* patch to do so. Unless somebody finds this
interesting and prods me, I don't plan to do something further with
this. If we were to go with this, some cleanup would be needed.

Greetings,

Andres Freund

Attachments:

t37513_1
0001-WIP-Combine-expr-Type-Typmod-Collation-into-one-func.patchtext/x-diff; charset=us-asciiDownload+435-508