[PATCH] Comment typo in get_collation_name() comment

Started by Dagfinn Ilmari Mannsåkerover 8 years ago4 messageshackers
Jump to latest

Hi Hackers,

The comment for get_collation_name() seems to have been copy-pasted from
get_constraint_name(), but missed one s/constraint/collation/.

Patch attached.

--
"I use RMS as a guide in the same way that a boat captain would use
a lighthouse. It's good to know where it is, but you generally
don't want to find yourself in the same spot." - Tollef Fog Heen

Attachments:

fix-get_collation_type-comment-typo.patchtext/x-diffDownload+1-1
In reply to: Dagfinn Ilmari Mannsåker (#1)
Re: [PATCH] Comment typo in get_collation_name() comment

ilmari@ilmari.org (Dagfinn Ilmari Mannsåker) writes:

Hi Hackers,

The comment for get_collation_name() seems to have been copy-pasted from
get_constraint_name(), but missed one s/constraint/collation/.

Patch attached.

Bump? Do I need to add this patch to the next commitfest? I thought
trivial comment typo patches like this generally got commited without
such bureaucracy?

- ilmari
--
"I use RMS as a guide in the same way that a boat captain would use
a lighthouse. It's good to know where it is, but you generally
don't want to find yourself in the same spot." - Tollef Fog Heen

#3Alvaro Herrera
alvherre@2ndquadrant.com
In reply to: Dagfinn Ilmari Mannsåker (#2)
Re: [PATCH] Comment typo in get_collation_name() comment

Dagfinn Ilmari Manns�ker wrote:

ilmari@ilmari.org (Dagfinn Ilmari Manns�ker) writes:

Hi Hackers,

The comment for get_collation_name() seems to have been copy-pasted from
get_constraint_name(), but missed one s/constraint/collation/.

Patch attached.

Bump? Do I need to add this patch to the next commitfest? I thought
trivial comment typo patches like this generally got commited without
such bureaucracy?

The problem is that pg-hackers is now too much traffic, so unregistered
patches customarily fall through cracks. Recommendation is to register
all patches to avoid that problem.

I have pushed it now.

--
�lvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

In reply to: Alvaro Herrera (#3)
Re: [PATCH] Comment typo in get_collation_name() comment

Alvaro Herrera <alvherre@alvh.no-ip.org> writes:

The problem is that pg-hackers is now too much traffic, so unregistered
patches customarily fall through cracks. Recommendation is to register
all patches to avoid that problem.

I shall keep that in mind and register even trivial patches in future if
they don't get picked up straight away.

I have pushed it now.

Thanks!

- ilmari
--
"The surreality of the universe tends towards a maximum" -- Skud's Law
"Never formulate a law or axiom that you're not prepared to live with
the consequences of." -- Skud's Meta-Law