Skip unneeded temp file in 'make html'

Started by David Fetterover 8 years ago3 messageshackers
Jump to latest
#1David Fetter
david@fetter.org

Folks,

Please find attached a patch for $Subject.

Best,
David.
--
David Fetter <david(at)fetter(dot)org> http://fetter.org/
Phone: +1 415 235 3778

Remember to vote!
Consider donating to Postgres: http://www.postgresql.org/about/donate

Attachments:

0001-Don-t-make-an-unneeded-temp-file.patchtext/x-diff; charset=us-asciiDownload+3-6
#2Peter Eisentraut
peter_e@gmx.net
In reply to: David Fetter (#1)
Re: Skip unneeded temp file in 'make html'

On 11/2/17 22:07, David Fetter wrote:

postgres.xml: $(srcdir)/postgres.sgml $(ALLSGML)
-	$(OSX) $(SPFLAGS) $(SGMLINCLUDE) -x lower $< >$@.tmp
-	$(call mangle-xml,book)
+	$(OSX) $(SPFLAGS) $(SGMLINCLUDE) -x lower $< | $(call mangle-xml,book)

The reason why it's not done that way is that this would not catch
errors of the command before the pipe.

--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

#3David Fetter
david@fetter.org
In reply to: Peter Eisentraut (#2)
Re: Skip unneeded temp file in 'make html'

On Fri, Nov 03, 2017 at 11:34:18AM -0400, Peter Eisentraut wrote:

On 11/2/17 22:07, David Fetter wrote:

postgres.xml: $(srcdir)/postgres.sgml $(ALLSGML)
-	$(OSX) $(SPFLAGS) $(SGMLINCLUDE) -x lower $< >$@.tmp
-	$(call mangle-xml,book)
+	$(OSX) $(SPFLAGS) $(SGMLINCLUDE) -x lower $< | $(call mangle-xml,book)

The reason why it's not done that way is that this would not catch
errors of the command before the pipe.

Thanks for clarifying.

Best,
David.
--
David Fetter <david(at)fetter(dot)org> http://fetter.org/
Phone: +1 415 235 3778

Remember to vote!
Consider donating to Postgres: http://www.postgresql.org/about/donate

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers