CI
Applieswon't retry9y behind master
Buildsuccess1m 51s / 2m 37s
Tests467 / 467
GitHub runGitHub branchCI history
Participants
David Fetter
David Fetter
Peter Eisentraut
Peter Eisentraut
Attachments
Download Latest Patchset
+3-6
Show all attachments
Show all patchsets
Thread Outline
#1David FetterDavid Fetter
Nov 03, 2017
#2Peter Eisentraut↳Peter Eisentrautto David Fetter (#1)
Nov 03, 2017
#3David Fetter↳David Fetterto Peter Eisentraut (#2)
Nov 03, 2017

Skip unneeded temp file in 'make html'

Started by David Fetteralmost 9 years ago3 messageshackers
Beta feature

Hackorum builds and tests every patch posted to the lists, not only commitfest submissions. This is Hackorum's own CI rather than the PostgreSQL project's, and it is still under testing - please report anything that looks wrong.

won't retrysuccessCI history

You can run a PostgreSQL built from this patch straight from Docker, with no checkout and no build:

docker run --rm -p 5432:5432 ghcr.io/hackorum-dev/postgres-patch:t37671
psql -h localhost -U postgres

Built from patchset v1 (message #1), July 27, 2026 at 09:53 PM.

Every patchset is also pushed to a branch of our PostgreSQL fork, so you can check out the same tree CI built. Without a PostgreSQL checkout:

git clone --branch t37671_1 https://github.com/hackorum-dev/postgres.git

In a checkout you already have, add the fork once:

git remote add hackorum https://github.com/hackorum-dev/postgres.git

then, for this patchset and every later one:

git fetch hackorum t37671_1 && git checkout t37671_1

Patchset v1 (message #1) is on t37671_1

Jump to latest
#1David Fetter
David Fetter
david@fetter.org

Folks,

Please find attached a patch for $Subject.

Best,
David.
--
David Fetter <david(at)fetter(dot)org> http://fetter.org/
Phone: +1 415 235 3778

Remember to vote!
Consider donating to Postgres: http://www.postgresql.org/about/donate

Attachments:

t37671_1
0001-Don-t-make-an-unneeded-temp-file.patchtext/x-diff; charset=us-asciiDownload+3-6
#2Peter Eisentraut
Peter Eisentraut
peter_e@gmx.net
In reply to: David Fetter (#1)
Re: Skip unneeded temp file in 'make html'

On 11/2/17 22:07, David Fetter wrote:

postgres.xml: $(srcdir)/postgres.sgml $(ALLSGML)
-	$(OSX) $(SPFLAGS) $(SGMLINCLUDE) -x lower $< >$@.tmp
-	$(call mangle-xml,book)
+	$(OSX) $(SPFLAGS) $(SGMLINCLUDE) -x lower $< | $(call mangle-xml,book)

The reason why it's not done that way is that this would not catch
errors of the command before the pipe.

--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

#3David Fetter
David Fetter
david@fetter.org
In reply to: Peter Eisentraut (#2)
Re: Skip unneeded temp file in 'make html'

On Fri, Nov 03, 2017 at 11:34:18AM -0400, Peter Eisentraut wrote:

On 11/2/17 22:07, David Fetter wrote:

postgres.xml: $(srcdir)/postgres.sgml $(ALLSGML)
-	$(OSX) $(SPFLAGS) $(SGMLINCLUDE) -x lower $< >$@.tmp
-	$(call mangle-xml,book)
+	$(OSX) $(SPFLAGS) $(SGMLINCLUDE) -x lower $< | $(call mangle-xml,book)

The reason why it's not done that way is that this would not catch
errors of the command before the pipe.

Thanks for clarifying.

Best,
David.
--
David Fetter <david(at)fetter(dot)org> http://fetter.org/
Phone: +1 415 235 3778

Remember to vote!
Consider donating to Postgres: http://www.postgresql.org/about/donate

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

← Back to Topics