Re: scan-build plpython stuff

Started by John Naylorover 8 years ago3 messageshackers
Jump to latest
#1John Naylor
john.naylor@enterprisedb.com

Peter,

I built plpython with scan-build using Python 2.7.12 and Clang 3.8. On
master, I got 13 warnings, and with your patches only one warning
(report attached).

Make installcheck passes.
Let me know if I can test anything else.

-John Naylor

Attachments:

report-d87fac.htmltext/html; charset=US-ASCII; name=report-d87fac.htmlDownload
#2Peter Eisentraut
peter_e@gmx.net
In reply to: John Naylor (#1)

On 11/24/17 08:40, John Naylor wrote:

I built plpython with scan-build using Python 2.7.12 and Clang 3.8. On
master, I got 13 warnings, and with your patches only one warning
(report attached).

Thanks for testing. That one bug is actually a new one, recently
introduced by me. I have pushed a separate fix for that one.

--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

#3John Naylor
john.naylor@enterprisedb.com
In reply to: Peter Eisentraut (#2)

On 11/28/17, Peter Eisentraut <peter.eisentraut@2ndquadrant.com> wrote:

On 11/24/17 08:40, John Naylor wrote:

I built plpython with scan-build using Python 2.7.12 and Clang 3.8. On
master, I got 13 warnings, and with your patches only one warning
(report attached).

Thanks for testing. That one bug is actually a new one, recently
introduced by me. I have pushed a separate fix for that one.

OK, I've marked this one ready for committer.

-John