Obsolete fmgr() declaration in fmgr.h

Started by Dagfinn Ilmari Mannsåkerabout 8 years ago3 messageshackers
Jump to latest

Hi Hackers,

Commit 5ded4bd21403e143dd3eb66b92d52732fdac1945 removed support for
version-0 function calling convention, and with it the fmgr() function.
However, the declaration was left behind in fmgr.h. The attached patch
finishes the cleanup.

Regards,

- ilmari
--
"I use RMS as a guide in the same way that a boat captain would use
a lighthouse. It's good to know where it is, but you generally
don't want to find yourself in the same spot." - Tollef Fog Heen

Attachments:

0001-Remove-left-over-fmgr-declaration.patchtext/x-diffDownload+0-16
#2Robert Haas
robertmhaas@gmail.com
In reply to: Dagfinn Ilmari Mannsåker (#1)
Re: Obsolete fmgr() declaration in fmgr.h

On Tue, Feb 6, 2018 at 9:37 AM, Dagfinn Ilmari Mannsåker
<ilmari@ilmari.org> wrote:

Commit 5ded4bd21403e143dd3eb66b92d52732fdac1945 removed support for
version-0 function calling convention, and with it the fmgr() function.
However, the declaration was left behind in fmgr.h. The attached patch
finishes the cleanup.

Committed.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In reply to: Robert Haas (#2)
Re: Obsolete fmgr() declaration in fmgr.h

Robert Haas <robertmhaas@gmail.com> writes:

On Tue, Feb 6, 2018 at 9:37 AM, Dagfinn Ilmari Mannsåker
<ilmari@ilmari.org> wrote:

Commit 5ded4bd21403e143dd3eb66b92d52732fdac1945 removed support for
version-0 function calling convention, and with it the fmgr() function.
However, the declaration was left behind in fmgr.h. The attached patch
finishes the cleanup.

Committed.

Thanks. Commitfest entry updated
(https://commitfest.postgresql.org/17/1512/).

- ilmari
--
- Twitter seems more influential [than blogs] in the 'gets reported in
the mainstream press' sense at least. - Matt McLeod
- That'd be because the content of a tweet is easier to condense down
to a mainstream media article. - Calle Dybedahl