Isolation tester result formatting

Started by Thomas Munroabout 8 years ago2 messageshackers
Jump to latest
#1Thomas Munro
thomas.munro@gmail.com

Hi hackers,

Due to recent naming inflation, the isolation tester output has become
jagged (when viewed in a monospace font):

test lock-update-delete ... ok
test lock-update-traversal ... ok
test insert-conflict-do-nothing ... ok
test insert-conflict-do-nothing-2 ... ok
test insert-conflict-do-update ... ok
test insert-conflict-do-update-2 ... ok
test insert-conflict-do-update-3 ... ok
test insert-conflict-toast ... ok
test delete-abort-savept ... ok

If we widened the field by 4 spaces it'd fit all current test names:

test lock-update-delete ... ok
test lock-update-traversal ... ok
test insert-conflict-do-nothing ... ok
test insert-conflict-do-nothing-2 ... ok
test insert-conflict-do-update ... ok
test insert-conflict-do-update-2 ... ok
test insert-conflict-do-update-3 ... ok
test insert-conflict-toast ... ok
test delete-abort-savept ... ok

Patch attached. I realise this isn't the most pressing problem faced
by computer science...

--
Thomas Munro
http://www.enterprisedb.com

Attachments:

test-name-inflation-adjustment.patchapplication/octet-stream; name=test-name-inflation-adjustment.patchDownload+3-3
#2Andres Freund
andres@anarazel.de
In reply to: Thomas Munro (#1)
Re: Isolation tester result formatting

On 2018-02-23 23:33:15 +1300, Thomas Munro wrote:

Hi hackers,

Due to recent naming inflation, the isolation tester output has become
jagged (when viewed in a monospace font):

test lock-update-delete ... ok
test lock-update-traversal ... ok
test insert-conflict-do-nothing ... ok
test insert-conflict-do-nothing-2 ... ok
test insert-conflict-do-update ... ok
test insert-conflict-do-update-2 ... ok
test insert-conflict-do-update-3 ... ok
test insert-conflict-toast ... ok
test delete-abort-savept ... ok

If we widened the field by 4 spaces it'd fit all current test names:

test lock-update-delete ... ok
test lock-update-traversal ... ok
test insert-conflict-do-nothing ... ok
test insert-conflict-do-nothing-2 ... ok
test insert-conflict-do-update ... ok
test insert-conflict-do-update-2 ... ok
test insert-conflict-do-update-3 ... ok
test insert-conflict-toast ... ok
test delete-abort-savept ... ok

Patch attached. I realise this isn't the most pressing problem faced
by computer science...

Seems reasonable. Pushed. I can't make myself even remotely care enough
to backpatch even though "problem" existed for a while.

Thanks,

Andres