Missing break statement after transformCallStmt in transformStmt
HI,
Commit 76b6aa41f41db66004b1c430f17a546d4102fbe7 a new case for
CallStmt in transformStmt but forgot to add a break statement at the
end of the case. This doesn't create any problems since the default
case to which it continues without break doesn't change the result.
But this is going to cause problems in future when somebody adds a
case after CallStmt.
Here's patch with fix.
--
Best Wishes,
Ashutosh Bapat
EnterpriseDB Corporation
The Postgres Database Company
Attachments:
pg_call_break.patchtext/x-patch; charset=US-ASCII; name=pg_call_break.patchDownload+1-0
On Wed, Mar 07, 2018 at 11:30:53AM +0530, Ashutosh Bapat wrote:
Commit 76b6aa41f41db66004b1c430f17a546d4102fbe7 a new case for
CallStmt in transformStmt but forgot to add a break statement at the
end of the case. This doesn't create any problems since the default
case to which it continues without break doesn't change the result.
But this is going to cause problems in future when somebody adds a
case after CallStmt.
Indeed, this code is quite lucky to be able to run, and I can see that
the code path is stressed. What surprises me the most is that Coverity
did not complain about that, but wait... They are in maintenance mode
since the 20th of February:
https://twitter.com/CoverityScan/status/966068113941979136
--
Michael