Typos from Covering Index patch

Started by Michael Paquierabout 8 years ago4 messageshackers
Jump to latest
#1Michael Paquier
michael@paquier.xyz

Hi all,

I am catching up with new features so I have begun going through
Covering indexes. While reading the code, I have noticed a couple of
things:
1) Some typos.
2) An inconsistent variable name in pg_dump.

The thing and structure of the code is pretty interesting by the way.
That's nice work. I am still trying to break the DDL data like
NULL-ness of columns for some weird combinations of columns without
being able to.

Thanks,
--
Michael

Attachments:

covering-typos.patchtext/x-diff; charset=us-asciiDownload+7-6
#2Heikki Linnakangas
heikki.linnakangas@enterprisedb.com
In reply to: Michael Paquier (#1)
Re: Typos from Covering Index patch

On 11/04/18 03:52, Michael Paquier wrote:

Hi all,

I am catching up with new features so I have begun going through
Covering indexes. While reading the code, I have noticed a couple of
things:
1) Some typos.
2) An inconsistent variable name in pg_dump.

Committed, thanks!

- Heikki

#3Heikki Linnakangas
heikki.linnakangas@enterprisedb.com
In reply to: Michael Paquier (#1)
Re: Typos from Covering Index patch

On 11/04/18 03:52, Michael Paquier wrote:

Hi all,

I am catching up with new features so I have begun going through
Covering indexes. While reading the code, I have noticed a couple of
things:
1) Some typos.
2) An inconsistent variable name in pg_dump.

Committed, thanks!

- Heikki

#4Michael Paquier
michael@paquier.xyz
In reply to: Heikki Linnakangas (#3)
Re: Typos from Covering Index patch

On Tue, Apr 17, 2018 at 11:57:20AM -0400, Heikki Linnakangas wrote:

Committed, thanks!

Thanks, Heikki.
--
Michael