Fix for documentation of Covering Indexes

Started by Michael Paquierover 8 years ago4 messageshackersdocs
Beta feature

Hackorum builds and tests every patch posted to the lists, not only commitfest submissions. This is Hackorum's own CI rather than the PostgreSQL project's, and it is still under testing - please report anything that looks wrong.

won't retrysuccessCI history

You can run a PostgreSQL built from this patch straight from Docker, with no checkout and no build:

docker run --rm -p 5432:5432 ghcr.io/hackorum-dev/postgres-patch:t38537
psql -h localhost -U postgres

Built from patchset v4 (message #4), August 18, 2026 at 04:48 PM.

Every patchset is also pushed to a branch of our PostgreSQL fork, so you can check out the same tree CI built. Without a PostgreSQL checkout:

git clone --branch t38537_4 https://github.com/hackorum-dev/postgres.git

In a checkout you already have, add the fork once:

git remote add hackorum https://github.com/hackorum-dev/postgres.git

then, for this patchset and every later one:

git fetch hackorum t38537_4 && git checkout t38537_4

Patchset v4 (message #4) is on t38537_4

Jump to latest
#1Michael Paquier
michael@paquier.xyz
hackersdocs

Hi all,

The documentation of covering indexes is incorrect for CREATE and ALTER
TABLE:
- ALTER TABLE's page is missing the call.
- Exclusion constraints can use INCLUDE clauses.

In order to simplify the documentation, please let me suggest the
attached which moves the definition of the INCLUDE clause into the
section index_parameters, which is compatible with what I read from the
parser.

Thanks,
--
Michael

Attachments:

covering-index-docs.patchtext/x-diff; charset=us-asciiDownload+4-2
#2Heikki Linnakangas
heikki.linnakangas@enterprisedb.com
In reply to: Michael Paquier (#1)
hackersdocs
Re: Fix for documentation of Covering Indexes

On 11/04/18 04:20, Michael Paquier wrote:

Hi all,

The documentation of covering indexes is incorrect for CREATE and ALTER
TABLE:
- ALTER TABLE's page is missing the call.
- Exclusion constraints can use INCLUDE clauses.

In order to simplify the documentation, please let me suggest the
attached which moves the definition of the INCLUDE clause into the
section index_parameters, which is compatible with what I read from the
parser.

Committed, thanks!

- Heikki

#3Michael Paquier
michael@paquier.xyz
In reply to: Heikki Linnakangas (#2)
hackersdocs
Re: Fix for documentation of Covering Indexes

On Wed, Apr 18, 2018 at 05:52:01AM -0400, Heikki Linnakangas wrote:

Committed, thanks!

Thanks for the commit.
--
Michael

#4Liudmila Mantrova
l.mantrova@postgrespro.ru
In reply to: Heikki Linnakangas (#2)
hackersdocs
Re: Fix for documentation of Covering Indexes

On 04/18/2018 12:52 PM, Heikki Linnakangas wrote:

On 11/04/18 04:20, Michael Paquier wrote:

Hi all,

The documentation of covering indexes is incorrect for CREATE and ALTER
TABLE:
- ALTER TABLE's page is missing the call.
- Exclusion constraints can use INCLUDE clauses.

In order to simplify the documentation, please let me suggest the
attached which moves the definition of the INCLUDE clause into the
section index_parameters, which is compatible with what I read from the
parser.

Committed, thanks!

- Heikki

Following this change, I believe we need to modify UNIQUE and PRIMARY
KEY descriptions in CREATE TABLE as they still mention INCLUDE but not
the other index_parameters. The attached patch fixes this inconsistency,
as well as adds a separate paragraph for INCLUDE in CREATE TABLE to
clarify its purpose and avoid repetition in constraint descriptions. It
also reorders the paragraphs in CREATE INDEX to follow the syntax.

--
Liudmila Mantrova
Technical writer at Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company

Attachments:

t38537_4
include-clause-reference.patchtext/x-patch; name=include-clause-reference.patchDownload+82-64