FindDefinedSymbol() is subtly broken
Long story short: It expects an array of paths, but will die if it
can't find the symbol in the first path. Arguably it's a bug, but
since the original use case for multiple paths is long gone anyway, it
might never occur in practice. The attached patch changes it to expect
a single path.
Also attached: a few minor build script cleanups I've noticed along the way:
-more accurate error message
-s/print sprintf/printf/
-a recent perltidy change made a couple multi-line strings look odd,
so use heredocs (which other scripts use in this case anyway)
-make generated file footers match project style
-remove a duplicate comment
-John Naylor
Attachments:
0001-Update-FindDefinedSymbol-to-match-current-practice.patchtext/x-patch; charset=US-ASCII; name=0001-Update-FindDefinedSymbol-to-match-current-practice.patchDownload+21-26
last-minute-script-cleanups.patchtext/x-patch; charset=US-ASCII; name=last-minute-script-cleanups.patchDownload+14-16
John Naylor <jcnaylor@gmail.com> writes:
Long story short: It expects an array of paths, but will die if it
can't find the symbol in the first path. Arguably it's a bug, but
since the original use case for multiple paths is long gone anyway, it
might never occur in practice. The attached patch changes it to expect
a single path.
Also attached: a few minor build script cleanups I've noticed along the way:
-more accurate error message
-s/print sprintf/printf/
-a recent perltidy change made a couple multi-line strings look odd,
so use heredocs (which other scripts use in this case anyway)
-make generated file footers match project style
-remove a duplicate comment
This all seemed like minor cleanup from v11 changes, so I went
ahead and pushed it rather than waiting for v12.
regards, tom lane