Incorrect comments in commit_ts.c

Started by shao bretalmost 8 years ago3 messageshackers

bret.shao@outlook.com

almost 8 years ago

Hi,

Here is the comment for CommitTsPagePrecedes in commit_ts.c
/*
* Decide which of two CLOG page numbers is "older" for truncation purposes.
…
*/
I think there is some mistake for this comment. It should be ‘commitTS page’, not ‘CLOG page’.

Thanks,
Br.
Bret

发送自 Windows 10 版邮件<https://go.microsoft.com/fwlink/?LinkId=550986>应用

Michael Paquier

michael@paquier.xyz

almost 8 years ago

In reply to: shao bret (#1)

Re: Incorrect comments in commit_ts.c

On Fri, Jun 22, 2018 at 03:45:01AM +0000, shao bret wrote:

I think there is some mistake for this comment. It should be
‘commitTS page’, not ‘CLOG page’.

You are right, so pushed.
--
Michael

shao bret

bret.shao@outlook.com

almost 8 years ago

In reply to: Michael Paquier (#2)

答复: Incorrect comments in commit_ts.c

Thanks, I have seen the code change.

Br.
Bret.

HighGo Software
Website：http://www.highgo.com/?l=en

发送自 Windows 10 版邮件<https://go.microsoft.com/fwlink/?LinkId=550986>应用

发件人: Michael Paquier<mailto:michael@paquier.xyz>
发送时间: 2018年6月22日 12:32
收件人: shao bret<mailto:bret.shao@outlook.com>
抄送: pgsql-hackers@lists.postgresql.org<mailto:pgsql-hackers@lists.postgresql.org>
主题: Re: Incorrect comments in commit_ts.c

On Fri, Jun 22, 2018 at 03:45:01AM +0000, shao bret wrote:

I think there is some mistake for this comment. It should be
‘commitTS page’, not ‘CLOG page’.

You are right, so pushed.
--
Michael

Incorrect comments in commit_ts.c

Attachments: