Incorrect comments in commit_ts.c
Hackorum builds and tests every patch posted to the lists, not only commitfest submissions. This is Hackorum's own CI rather than the PostgreSQL project's, and it is still under testing - please report anything that looks wrong.
Hi,
Here is the comment for CommitTsPagePrecedes in commit_ts.c
/*
* Decide which of two CLOG page numbers is "older" for truncation purposes.
…
*/
I think there is some mistake for this comment. It should be ‘commitTS page’, not ‘CLOG page’.
Thanks,
Br.
Bret
发送自 Windows 10 版邮件<https://go.microsoft.com/fwlink/?LinkId=550986>应用
Attachments:
001-incorrect-comments.patchapplication/octet-stream; name=001-incorrect-comments.patchDownload+1-1
On Fri, Jun 22, 2018 at 03:45:01AM +0000, shao bret wrote:
I think there is some mistake for this comment. It should be
‘commitTS page’, not ‘CLOG page’.
You are right, so pushed.
--
Michael
Thanks, I have seen the code change.
Br.
Bret.
HighGo Software
Website：http://www.highgo.com/?l=en
发送自 Windows 10 版邮件<https://go.microsoft.com/fwlink/?LinkId=550986>应用
发件人: Michael Paquier<mailto:michael@paquier.xyz>
发送时间: 2018年6月22日 12:32
收件人: shao bret<mailto:bret.shao@outlook.com>
抄送: pgsql-hackers@lists.postgresql.org<mailto:pgsql-hackers@lists.postgresql.org>
主题: Re: Incorrect comments in commit_ts.c
On Fri, Jun 22, 2018 at 03:45:01AM +0000, shao bret wrote:
I think there is some mistake for this comment. It should be
‘commitTS page’, not ‘CLOG page’.
You are right, so pushed.
--
Michael