XLogSegNoOffsetToRecPtr fixup

Started by Alvaro Herreraalmost 8 years ago2 messageshackers
Jump to latest
#1Alvaro Herrera
alvherre@2ndquadrant.com

Pursuant to closing comment in
/messages/by-id/20180306214239.ospkf6ie7aa5gm4j@alvherre.pgsql
here's a quick patch to change the order of arguments in
XLogSegNoOffsetToRecPtr. Commit fc49e24fa69a ("Make WAL segment size
configurable at initdb time.") put the walsegsz as last argument,
*after* its output argument, which is downright weird.

I propose to apply this to pg11 and master, to avoid an unnecessary API
change in pg12.

--
�lvaro Herrera http://www.flickr.com/photos/alvherre/

Attachments:

XLogSegNoOffsetToRecPtr.patchtext/plain; charset=us-asciiDownload+13-13
#2Andres Freund
andres@anarazel.de
In reply to: Alvaro Herrera (#1)
Re: XLogSegNoOffsetToRecPtr fixup

Hi,

On 2018-07-08 14:23:45 -0400, Alvaro Herrera wrote:

Pursuant to closing comment in
/messages/by-id/20180306214239.ospkf6ie7aa5gm4j@alvherre.pgsql
here's a quick patch to change the order of arguments in
XLogSegNoOffsetToRecPtr. Commit fc49e24fa69a ("Make WAL segment size
configurable at initdb time.") put the walsegsz as last argument,
*after* its output argument, which is downright weird.

I propose to apply this to pg11 and master, to avoid an unnecessary API
change in pg12.

WFM.

Thanks,

Andres