Shouldn't validateForeignKeyConstraint() reset memory context?

Started by Andres Freundalmost 8 years ago2 messageshackers
Jump to latest
#1Andres Freund
andres@anarazel.de

Hi,

while looking at the pluggable storage patch I noticed that
validateForeignKeyConstraint() calls RI_FKey_check() for each row
without resetting a memory / expression context. There's not too much
leakage in the called code, but there's some I think.

Greetings,

Andres Freund

#2Andres Freund
andres@anarazel.de
In reply to: Andres Freund (#1)
Re: Shouldn't validateForeignKeyConstraint() reset memory context?

Hi,

On 2018-07-11 11:56:28 -0700, Andres Freund wrote:

while looking at the pluggable storage patch I noticed that
validateForeignKeyConstraint() calls RI_FKey_check() for each row
without resetting a memory / expression context. There's not too much
leakage in the called code, but there's some I think.

This has been fixed since. See /messages/by-id/20190408055302.qirqcbnhjxwsxq3m@alap3.anarazel.de

- Andres