Oct 2025

6 commits
Fix coding style with "else".
23 Oct 2025Tatsuo Ishiimaster19beta1REL_19_STABLE19beta1
LLM analysis, 100% surelanded as postedfrom patchset #1212 of 2 reviewers saw the final version

The nodeWindowAgg.c hunk exactly matches #121, replacing the blank line after else with an opening brace and adding its closing brace; #122 confirms the push.

  • Chao Lisaw the final versionLLM analysis, 99% sureIdentified the anomalous blank line in the same else block in #117, initiating the light style correction.
  • David Rowleysaw the final versionLLM analysis, 100% sureExplained in #120 that a separate-line comment requires braces, which #121 implements.
Fix multi WinGetFuncArgInFrame/Partition calls with IGNORE NULLS.
22 Oct 2025Tatsuo Ishiimaster19beta1REL_19_STABLE19beta1
LLM analysis, 100% surelanded as postedfrom patchset #1161 of 2 reviewers saw the final version

All added and removed lines in nodeWindowAgg.c match #116, including lazy per-argument caches, per-argument capacities, memory-context handling, and conservative marks; #119 confirms the push.

  • Tom Lanesaw an earlier versionLLM analysis, 99% sureReported the single-argument cache assumption and requested lazily allocated per-argument arrays in #98, before the subsequent implementation and mark-handling revisions.
  • Chao Lisaw the final versionLLM analysis, 98% sureReviewed the final attachment's else-block formatting in #117 before this commit, with the correction deferred to a later commit.
Fix Coverity issue reported in commit 2273fa32bce.
19 Oct 2025Tatsuo Ishiimaster19beta1REL_19_STABLE19beta1
LLM analysis, 100% surelanded as postedfrom patchset #1122 of 2 reviewers saw the final version

The nodeWindowAgg.c changes exactly match #112, including the void cast and helper comments; the minor wording adjustments mentioned in #114 do not change the attached diff.

  • Michael Paquiersaw the final versionLLM analysis, 97% sureReported the overwritten datum and insufficient helper documentation in #111, leading to the light cleanup in #112.
  • Chao Lisaw the final versionLLM analysis, 98% sureExamined the remaining repeated helper call in #113 before the patch was committed.
Use ereport rather than elog in WinCheckAndInitializeNullTreatment.
14 Oct 2025Tatsuo Ishiimaster19beta1REL_19_STABLE19beta1
LLM analysis, 100% surelanded as postedfrom patchset #1070 of 1 reviewer saw the final version

The WinCheckAndInitializeNullTreatment diff exactly matches #107, including ereport, get_func_name, the assertion, and the null-result guard; #110 confirms that version was pushed.

  • Chao Lisaw an earlier versiontrailerSuggested const char in #101, after which #107 also introduced a new null-result error path and an assertion without a further recorded review.
Fix Coverity issues reported in commit 25a30bbd423.
8 Oct 2025Tatsuo Ishiimaster19beta1REL_19_STABLE19beta1
LLM analysis, 100% surelanded as postedfrom patchset #941 of 1 reviewer saw the final version

The complete nodeWindowAgg.c diff matches #94, including myisout, checked tuple fetching, and the rewritten partition loop; #97 explicitly confirms that version was pushed.

  • Paul Ramseysaw the final versiontrailerReported successful regression testing, code inspection, and restored PostGIS operation in #95.
Add IGNORE NULLS/RESPECT NULLS option to Window functions.
3 Oct 2025Tatsuo Ishiimaster19beta1REL_19_STABLE19beta1
LLM analysis, 100% suremodified before commitlight changesfrom patchset #832 of 7 reviewers saw the final version

Combines the six patches in #83, restores doc/src/sgml/syntax.sgml and src/backend/catalog/sql_features.txt changes, and corrects one nodeWindowAgg.c comment; #85 confirms the restoration, while #83 explicitly credits Oliver Ford as author and Tatsuo Ishii as co-author.

  • Krasiyan Andreevsaw an earlier versiontrailerReported production and regression testing in #3, reproduced the memory-lifetime failure in #46, and tested through #68 in #69, before the row_is_in_frame refactor.
  • Andrew Gierthsaw an earlier versiontrailerRejected the special-type and grammar-precedence design in #4 and developed alternative parsing and API designs through #13.
  • Tom Lanesaw the final versiontrailerAlthough #98 disclaims substantive pre-commit review, his post-commit inspections in #86 and #98 examine the landed implementation and identify concrete API and cache defects.
  • David Fettersaw an earlier versiontrailerInspected and updated the initial patch's catalog OIDs and associated tests in #2, before the implementation was substantially rewritten.
  • Vik Fearingsaw an earlier versiontrailerReviewed marking, extensibility, and keyword choices in #19, then identified the incorrect acceptance of RESPECT NULLS on aggregates in #29.
  • David G. Johnstonsaw an earlier versiontrailerClarified null-treatment semantics and supported rejecting the clause for zero-argument functions in #32, before the API and cache redesigns.
  • Chao Lisaw the final versiontrailerGave an overall positive review with constant, field-size, and readability suggestions in #78, followed by light cleanup, tests, and documentation changes.

Credits across 6 commits

Author
Tatsuo Ishii1 LLM5
Oliver Ford1
Reviewer
Chao Li2
Andrew Gierth1
David Fetter1
David G. Johnston1
Krasiyan Andreev1
Paul Ramsey1
Tom Lane1
Vik Fearing1
Reported by
Tom Lane3
Alvaro Herrera1
Chao Li1
Michael Paquier1
Co author
Tatsuo Ishii1
Committer
Tatsuo Ishii6

N LLM means N of the credits come from LLM analysis, not from commit trailers.