Inconsistent error message in bt_page_items_bytea().

Started by Ashutosh Sharmaover 7 years ago2 messageshackers
Jump to latest
#1Ashutosh Sharma
ashu.coek88@gmail.com

Hi All,

All the pageinspect functions dealing with raw page has the error
message as "must be superuser to use raw page function" however,
that's not true for bt_page_items_bytea() which has "must be
superuser to use pageinspect functions". This seems to me like a copy
paste error which got transferred from bt_page_items (the function
that doesn't deal with raw page).

Attached is the patch with the correct error message.

--
With Regards,
Ashutosh Sharma
EnterpriseDB:http://www.enterprisedb.com

Attachments:

fix-error-message_bt_page_items_bytea.patchtext/x-patch; charset=US-ASCII; name=fix-error-message_bt_page_items_bytea.patchDownload+1-1
#2Michael Paquier
michael@paquier.xyz
In reply to: Ashutosh Sharma (#1)
Re: Inconsistent error message in bt_page_items_bytea().

On Fri, Jul 27, 2018 at 05:13:37PM +0530, Ashutosh Sharma wrote:

All the pageinspect functions dealing with raw page has the error
message as "must be superuser to use raw page function" however,
that's not true for bt_page_items_bytea() which has "must be
superuser to use pageinspect functions". This seems to me like a copy
paste error which got transferred from bt_page_items (the function
that doesn't deal with raw page).

Agreed. get_raw_page_internal() mentions "must be superuser to use raw
functions" which is inconsistent with the rest, so I fixed this second
one and pushed. Thanks!
--
Michael