Pithy patch for more detailed error reporting when effective_io_concurrency is set to nonzero on platforms lacking posix_fadvise()
Started by James Robinsonover 7 years ago2 messageshackers
Per Tom's suggestion on bug #15396, here's a patch to have platforms such as OSX give a more descriptive message when rejecting a nonzero value for effective_io_concurrency.
I had to adjust the GUC's wiring in the #ifndef case so that check_effective_io_concurrency() would be called when a nonzero value is supplied instead of just short-circuiting in parse_and_validate_value() when outside of [conf->min, conf->max].
James
Attachments:
no_fadvise_better_warning_bug_15396.patchapplication/octet-stream; name=no_fadvise_better_warning_bug_15396.patch; x-unix-mode=0644Download+6-1
Re: Pithy patch for more detailed error reporting when effective_io_concurrency is set to nonzero on platforms lacking posix_fadvise()
James Robinson <james@jlr-photo.com> writes:
Per Tom's suggestion on bug #15396, here's a patch to have platforms such as OSX give a more descriptive message when rejecting a nonzero value for effective_io_concurrency.
Pushed with minor editorialization.
regards, tom lane