remove deprecated @@@ operator ?
Hello,
The commit 9b5c8d45f62bd3d243a40cc84deb93893f2f5122 is now 10+ years
old, may be we could remove deprecated @@@ operator ?
Author: Tom Lane <tgl@sss.pgh.pa.us>
Date: Mon Apr 14 17:05:34 2008 +0000
Push index operator lossiness determination down to GIST/GIN opclass
"consistent" functions, and remove pg_amop.opreqcheck, as per recent
discussion. The main immediate benefit of this is that we no longer need
8.3's ugly hack of requiring @@@ rather than @@ to test weight-using tsquery
searches on GIN indexes. In future it should be possible to optimize some
other queries better than is done now, by detecting at runtime whether the
index match is exact or not.
Tom Lane, after an idea of Heikki's, and with some help from Teodor.
Best Regards,
Oleg
--
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company
Oleg Bartunov <obartunov@postgrespro.ru> writes:
The commit 9b5c8d45f62bd3d243a40cc84deb93893f2f5122 is now 10+ years
old, may be we could remove deprecated @@@ operator ?
Is it actually causing any problem? AFAICS it's just a couple extra
pg_operator entries, so why not leave it?
I'd be +1 for removing it from the docs, though ...
regards, tom lane
On Sun, Oct 21, 2018 at 11:24 PM Tom Lane <tgl@sss.pgh.pa.us> wrote:
Oleg Bartunov <obartunov@postgrespro.ru> writes:
The commit 9b5c8d45f62bd3d243a40cc84deb93893f2f5122 is now 10+ years
old, may be we could remove deprecated @@@ operator ?Is it actually causing any problem? AFAICS it's just a couple extra
pg_operator entries, so why not leave it?I'd be +1 for removing it from the docs, though ...
attached a tiny patch for docs
regards, tom lane
--
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company
Attachments:
func.sgml.patchapplication/octet-stream; name=func.sgml.patchDownload
--- func.sgml.old 2018-10-04 14:06:21.000000000 +0300
+++ func.sgml 2018-10-21 23:07:46.000000000 +0300
@@ -9480,13 +9480,6 @@
<entry><literal>t</literal></entry>
</row>
<row>
- <entry> <literal>@@@</literal> </entry>
- <entry><type>boolean</type></entry>
- <entry>deprecated synonym for <literal>@@</literal></entry>
- <entry><literal>to_tsvector('fat cats ate rats') @@@ to_tsquery('cat & rat')</literal></entry>
- <entry><literal>t</literal></entry>
- </row>
- <row>
<entry> <literal>||</literal> </entry>
<entry><type>tsvector</type></entry>
<entry>concatenate <type>tsvector</type>s</entry>
On Sun, Oct 21, 2018 at 04:24:16PM -0400, Tom Lane wrote:
Oleg Bartunov <obartunov@postgrespro.ru> writes:
The commit 9b5c8d45f62bd3d243a40cc84deb93893f2f5122 is now 10+ years
old, may be we could remove deprecated @@@ operator ?Is it actually causing any problem? AFAICS it's just a couple extra
pg_operator entries, so why not leave it?I'd be +1 for removing it from the docs, though ...
Done in the attached patch.
--
Bruce Momjian <bruce@momjian.us> https://momjian.us
EDB https://enterprisedb.com
Only you can decide what is important to you.
Attachments:
oper.difftext/x-diff; charset=us-asciiDownload
diff --git a/doc/src/sgml/func.sgml b/doc/src/sgml/func.sgml
index d963f0a0a0..e39c815532 100644
--- a/doc/src/sgml/func.sgml
+++ b/doc/src/sgml/func.sgml
@@ -13124,24 +13124,6 @@ CREATE TYPE rainbow AS ENUM ('red', 'orange', 'yellow', 'green', 'blue', 'purple
</para></entry>
</row>
- <row>
- <entry role="func_table_entry"><para role="func_signature">
- <type>tsvector</type> <literal>@@@</literal> <type>tsquery</type>
- <returnvalue>boolean</returnvalue>
- </para>
- <para role="func_signature">
- <type>tsquery</type> <literal>@@@</literal> <type>tsvector</type>
- <returnvalue>boolean</returnvalue>
- </para>
- <para>
- This is a deprecated synonym for <literal>@@</literal>.
- </para>
- <para>
- <literal>to_tsvector('fat cats ate rats') @@@ to_tsquery('cat & rat')</literal>
- <returnvalue>t</returnvalue>
- </para></entry>
- </row>
-
<row>
<entry role="func_table_entry"><para role="func_signature">
<type>tsvector</type> <literal>||</literal> <type>tsvector</type>
diff --git a/doc/src/sgml/gin.sgml b/doc/src/sgml/gin.sgml
index d68d12d515..be02966e77 100644
--- a/doc/src/sgml/gin.sgml
+++ b/doc/src/sgml/gin.sgml
@@ -129,9 +129,6 @@
<entry morerows="1" valign="middle"><literal>tsvector_ops</literal></entry>
<entry><literal>@@ (tsvector,tsquery)</literal></entry>
</row>
- <row>
- <entry><literal>@@@ (tsvector,tsquery)</literal></entry>
- </row>
</tbody>
</tgroup>
</table>
On Thu, Nov 9, 2023 at 06:40:55PM -0500, Bruce Momjian wrote:
On Sun, Oct 21, 2018 at 04:24:16PM -0400, Tom Lane wrote:
Oleg Bartunov <obartunov@postgrespro.ru> writes:
The commit 9b5c8d45f62bd3d243a40cc84deb93893f2f5122 is now 10+ years
old, may be we could remove deprecated @@@ operator ?Is it actually causing any problem? AFAICS it's just a couple extra
pg_operator entries, so why not leave it?I'd be +1 for removing it from the docs, though ...
Done in the attached patch.
Patch applied to master.
--
Bruce Momjian <bruce@momjian.us> https://momjian.us
EDB https://enterprisedb.com
Only you can decide what is important to you.